LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net> To: alsa-devel@alsa-project.org, Brian Austin <brian.austin@cirrus.com>, Jaroslav Kysela <perex@perex.cz>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Paul Handrigan <Paul.Handrigan@cirrus.com>, Takashi Iwai <tiwai@suse.com> Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: [PATCH 2/2] ASoC: cs42l56: Improve two size determinations in cs42l56_i2c_probe() Date: Thu, 23 Nov 2017 09:45:19 +0100 [thread overview] Message-ID: <8c36fc94-1f7d-5d22-7d3a-f2f6117199aa@users.sourceforge.net> (raw) In-Reply-To: <d722241a-dca3-dac3-8288-ac2e283e8be8@users.sourceforge.net> From: Markus Elfring <elfring@users.sourceforge.net> Date: Thu, 23 Nov 2017 09:33:15 +0100 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- sound/soc/codecs/cs42l56.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c index 13ee46217d78..fd7b8d32c2b2 100644 --- a/sound/soc/codecs/cs42l56.c +++ b/sound/soc/codecs/cs42l56.c @@ -1190,9 +1190,7 @@ static int cs42l56_i2c_probe(struct i2c_client *i2c_client, unsigned int alpha_rev, metal_rev; unsigned int reg; - cs42l56 = devm_kzalloc(&i2c_client->dev, - sizeof(struct cs42l56_private), - GFP_KERNEL); + cs42l56 = devm_kzalloc(&i2c_client->dev, sizeof(*cs42l56), GFP_KERNEL); if (cs42l56 == NULL) return -ENOMEM; cs42l56->dev = &i2c_client->dev; @@ -1207,8 +1205,7 @@ static int cs42l56_i2c_probe(struct i2c_client *i2c_client, if (pdata) { cs42l56->pdata = *pdata; } else { - pdata = devm_kzalloc(&i2c_client->dev, - sizeof(struct cs42l56_platform_data), + pdata = devm_kzalloc(&i2c_client->dev, sizeof(*pdata), GFP_KERNEL); if (!pdata) return -ENOMEM; -- 2.15.0
next prev parent reply other threads:[~2017-11-23 8:46 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-23 8:42 [PATCH 0/2] ASoC: cs42l56: Adjustments for cs42l56_i2c_probe() SF Markus Elfring 2017-11-23 8:44 ` [PATCH 1/2] ASoC: cs42l56: Delete an error message for a failed memory allocation in cs42l56_i2c_probe() SF Markus Elfring 2017-11-27 18:53 ` Applied "ASoC: cs42l56: Delete an error message for a failed memory allocation in cs42l56_i2c_probe()" to the asoc tree Mark Brown 2017-11-23 8:45 ` SF Markus Elfring [this message] 2017-11-27 18:53 ` Applied "ASoC: cs42l56: Improve two size determinations " Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8c36fc94-1f7d-5d22-7d3a-f2f6117199aa@users.sourceforge.net \ --to=elfring@users.sourceforge.net \ --cc=Paul.Handrigan@cirrus.com \ --cc=alsa-devel@alsa-project.org \ --cc=brian.austin@cirrus.com \ --cc=broonie@kernel.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).