From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752340AbdKWIqk (ORCPT ); Thu, 23 Nov 2017 03:46:40 -0500 Received: from mout.web.de ([212.227.15.4]:63545 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751468AbdKWIqi (ORCPT ); Thu, 23 Nov 2017 03:46:38 -0500 Subject: [PATCH 2/2] ASoC: cs42l56: Improve two size determinations in cs42l56_i2c_probe() From: SF Markus Elfring To: alsa-devel@alsa-project.org, Brian Austin , Jaroslav Kysela , Liam Girdwood , Mark Brown , Paul Handrigan , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <8c36fc94-1f7d-5d22-7d3a-f2f6117199aa@users.sourceforge.net> Date: Thu, 23 Nov 2017 09:45:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:hYxYJobe6wX3Uyl2G3p+G6vmm3b88m9eHb3qqme33gOgptZBw3K gIrZUgNUhMQ7QTc2BCo6S8xoXv5VQNg226Ees2Ky25goZ4P9tB4fRoRyuj0cEJtE7xoFCON LrTt2Ixc5mL+417Nr16SDocx8Tq/qBt0rGqmJ+fs64JF9R4VqBIbMuoEAZr04l3TXG2nB4G C1PNfxBvGK8RytYdTuP3A== X-UI-Out-Filterresults: notjunk:1;V01:K0:fBOejyM16tA=:IEs2V1Ig8fwDItnjuuaqFh yhX94jH4wGQIv40uhZoHl1SNR16wYOCv7cvk0BsGvr1XFZR1eTP8pIuxF4XrIf0tL/yCOPY3U inBCk7TqS6/6zxDSHy85lqRL4FX9JePLaoq77Bo6qDsfNJ2agx6jefb+cM6fPUgmG0EsmxYkR B7KsKxysFekA1oCgRBv8DXw7ljlRC+AVMJKp8BtMpMJBTYl9fNf1WhPwZwKceNktedNxM3N8y f+V17Xe48V1h+h5hPIZS/Y2xm0Vujt2Uj5boozOu3gGfA1p5+Ut7xxMz+8os/tHY3wIw0feLD Ak6Hu7HD02e2G415fD6xDaFmMFotFSBASPVnH1DG1Hl7A9Osz79n7wRg48rIiR0RDwoz3i+lk 11dT3ISFdQl8AclWeiaKfrY87XpKVXP8VbB7f74OluISp6bwOSoRMCR37ei6jtV+Zy2G2q6Mw +XwgXKLRBO5KaAdib2fNyyQgrq8mamY4vP8wbyTybENgX8o7pA56DkksDDBARrw2dhdxHmxbY cY7zHqdZAA0s3dvWzB/KN9PHoGkaMFeW1aDEJBjvb/t/8TEltGOwCH40/oMD9esJd694chS3F YhO+fGPPn0de4TGlJu5xoLU0cZopBOMVMLIEq11CcA84QmSumxA7Y+lrVstqCTukEhW7C6xik jtLZFCyOuuOiXuBxAYzQAIPzm47navRFgCpPzHOVn6alQqiOC5qEziarcloCPxDGiNesbR99B GcP6SMG0+Jk4v7vbwp/GjlkXTEbJ2iHzkTh6Mz1Bd6BbqBd9IjPJK2DcJpJmpu0Zu1SZPLAj4 S+H+USagAqUqshh83X935Hi6R+nkoKzEzxWsyyyVMzg1uMrv6Q= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 23 Nov 2017 09:33:15 +0100 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/soc/codecs/cs42l56.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c index 13ee46217d78..fd7b8d32c2b2 100644 --- a/sound/soc/codecs/cs42l56.c +++ b/sound/soc/codecs/cs42l56.c @@ -1190,9 +1190,7 @@ static int cs42l56_i2c_probe(struct i2c_client *i2c_client, unsigned int alpha_rev, metal_rev; unsigned int reg; - cs42l56 = devm_kzalloc(&i2c_client->dev, - sizeof(struct cs42l56_private), - GFP_KERNEL); + cs42l56 = devm_kzalloc(&i2c_client->dev, sizeof(*cs42l56), GFP_KERNEL); if (cs42l56 == NULL) return -ENOMEM; cs42l56->dev = &i2c_client->dev; @@ -1207,8 +1205,7 @@ static int cs42l56_i2c_probe(struct i2c_client *i2c_client, if (pdata) { cs42l56->pdata = *pdata; } else { - pdata = devm_kzalloc(&i2c_client->dev, - sizeof(struct cs42l56_platform_data), + pdata = devm_kzalloc(&i2c_client->dev, sizeof(*pdata), GFP_KERNEL); if (!pdata) return -ENOMEM; -- 2.15.0