From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EB4CC4320A for ; Mon, 23 Aug 2021 10:56:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 169216138B for ; Mon, 23 Aug 2021 10:56:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236198AbhHWK5P convert rfc822-to-8bit (ORCPT ); Mon, 23 Aug 2021 06:57:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234155AbhHWK5K (ORCPT ); Mon, 23 Aug 2021 06:57:10 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8573AC061575 for ; Mon, 23 Aug 2021 03:56:25 -0700 (PDT) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mI7cu-00036Y-20; Mon, 23 Aug 2021 12:56:24 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1mI7ct-0005KP-4l; Mon, 23 Aug 2021 12:56:23 +0200 Message-ID: <8c6674e387615b49bf2aa3304bd49c0e99e37094.camel@pengutronix.de> Subject: Re: [PATCH] reset: reset-zynqmp: Fixed the argument data type From: Philipp Zabel To: Michal Simek , linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com Cc: Sai Krishna Potthuri , linux-arm-kernel@lists.infradead.org Date: Mon, 23 Aug 2021 12:56:23 +0200 In-Reply-To: <925cebbe4eb73c7d0a536da204748d33c7100d8c.1624448778.git.michal.simek@xilinx.com> References: <925cebbe4eb73c7d0a536da204748d33c7100d8c.1624448778.git.michal.simek@xilinx.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, On Wed, 2021-06-23 at 13:46 +0200, Michal Simek wrote: > From: Sai Krishna Potthuri > > This patch changes the data type of the variable 'val' from > int to u32. > > Addresses-Coverity: argument of type "int *" is incompatible with parameter of type "u32 *" > Signed-off-by: Sai Krishna Potthuri > Signed-off-by: Michal Simek > --- > > drivers/reset/reset-zynqmp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c > index daa425e74c96..59dc0ff9af9e 100644 > --- a/drivers/reset/reset-zynqmp.c > +++ b/drivers/reset/reset-zynqmp.c > @@ -53,7 +53,8 @@ static int zynqmp_reset_status(struct reset_controller_dev *rcdev, > unsigned long id) > { > struct zynqmp_reset_data *priv = to_zynqmp_reset_data(rcdev); > - int val, err; > + int err; > + u32 val; > > err = zynqmp_pm_reset_get_status(priv->data->reset_id + id, &val); > if (err) Thank you, applied to reset/fixes. regards Philipp