From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756149AbeDXFz3 (ORCPT ); Tue, 24 Apr 2018 01:55:29 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:39759 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454AbeDXFzW (ORCPT ); Tue, 24 Apr 2018 01:55:22 -0400 X-Google-Smtp-Source: AIpwx4+qaHzANvo9SWWEPSyFuKe9rrf8pQ/8v9ubkVp42p6oTf4lzFIFKVWT1+i++OOPqvxZTzjC5w== Subject: Re: [PATCH] Input: xen-kbdfront - allow better run-time configuration To: Dmitry Torokhov Cc: Juergen Gross , xen-devel@lists.xenproject.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, lyan@suse.com, boris.ostrovsky@oracle.com, andrii_chepurnyi@epam.com, Oleksandr Andrushchenko References: <20180418150445.9805-1-andr2000@gmail.com> <2bff035e-303e-d644-5f51-5e64150c097c@gmail.com> <20180423185325.GB66646@dtor-ws> From: Oleksandr Andrushchenko Message-ID: <8ef84389-4659-d4bb-271f-53155062b7b6@gmail.com> Date: Tue, 24 Apr 2018 08:55:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180423185325.GB66646@dtor-ws> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/23/2018 09:53 PM, Dmitry Torokhov wrote: > On Thu, Apr 19, 2018 at 02:44:19PM +0300, Oleksandr Andrushchenko wrote: >> On 04/19/2018 02:25 PM, Juergen Gross wrote: >>> On 18/04/18 17:04, Oleksandr Andrushchenko wrote: >>>> From: Oleksandr Andrushchenko >>>> >>>> It is now only possible to control if multi-touch virtual device >>>> is created or not (via the corresponding XenStore entries), >>>> but keyboard and pointer devices are always created. >>> Why don't you want to go that route for keyboard and mouse, too? >>> Or does this really make no sense? >> Well, I would prefer not to touch anything outside Linux and >> this driver. And these settings seem to be implementation specific. >> So, this is why introduce Linux module parameters and don't extend >> the kbdif protocol. > Why do you consider this implementation specific? How other guests > decide to forego creation of relative pointer device or keyboard-like > device? > > You already have "features" for absolute pointing device and multitouch, > so please extend the protocol properly so you indeed do not code > something implementation-specific (i.e. module parameters). Ok, but in order to preserve the default behavior, e.g. pointer and keyboard devices are always created now, I'll have to have reverse features in the protocol:  - feature-no-pointer  - feature-no-keyboard The above may be set as a part of frontend's configuration and if missed are considered to be set to false. > > Thanks. >