LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <m.s.tsirkin@gmail.com>
To: "Pavel Machek" <pavel@ucw.cz>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Alexey Starikovskiy" <astarikovskiy@suse.de>,
	"Len Brown" <len.brown@intel.com>,
	linux-acpi@vger.kernel.org, "Jeff Garzik" <jeff@garzik.org>
Subject: Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Date: Tue, 26 Feb 2008 00:36:54 +0200	[thread overview]
Message-ID: <8f53421d0802251436vd98a97h5db6b8af3dc39d0@mail.gmail.com> (raw)
In-Reply-To: <20080225222023.GK2659@elf.ucw.cz>

On Tue, Feb 26, 2008 at 12:20 AM, Pavel Machek <pavel@ucw.cz> wrote:
>
> Hi!
>
>  > >  > >  > commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2
>  > >  > >  > Author: Pavel Machek <pavel@ucw.cz>
>  > >  > >  > Date:   Thu Feb 21 13:56:55 2008 +0100
>  > >  > >  >
>  > >  > >  >     power_state: get rid of write-only variable in SATA
>  > >  > >
>  > >  > >  This is pretty unlikely to be it. Can you double check that this patch
>  > >  > >  really breaks something?
>  > >  >
>  > >  > I did and it seems to: just reverting
>  > >  > 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 fixes resume for me.
>  > >  > 635adc28087ced0c843d2ecb6d4ae474d0e611cd which is
>  > >  > 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2~1
>  > >  > also resumes fine.
>  > >
>  > >  Hmm, I guess that should teach me about "simple cleanups".
>  > >
>  > >  Do you use any of:
>  > >
>  > >  ata/sata_inic162x.c
>  > >  ata/sata_nv.c
>  > >  ata/sata_sil24.c
>  > >
>  > >  by chance?
>  >
>  > I don't think so.
>  > Here are the only 3 ata modules I have built:
>  > drivers/ata/ahci.ko
>  > drivers/ata/ata_piix.ko
>  > drivers/ata/libata.ko
>  >
>  >
>  > ahci.c seems to look at power_state.
>  >
>  > static int ahci_pci_device_resume(struct pci_dev *pdev)
>  > {
>  >         struct ata_host *host = dev_get_drvdata(&pdev->dev);
>  >         int rc;
>  >
>  >         rc = ata_pci_device_do_resume(pdev);
>  >         if (rc)
>  >                 return rc;
>  >
>  >         if (pdev->dev.power.power_state.event == PM_EVENT_SUSPEND) {
>  >                 rc = ahci_reset_controller(host);
>  >                 if (rc)
>  >                         return rc;
>  >
>  >                 ahci_init_controller(host);
>  >         }
>
>  > Right?
>
>  Hmm, mystery partly solved... as you guessed it, this piece of code
>  was not in my tree.
>
>  (still, how can this cause autoresume after 5 seconds is a mystery to
>  me).
>
>
>                                                                 Pavel

Maybe it doesn't. Andrew saw the autoresume on -rc[2,3], I didn't.
For me, it causes resume to fail.

  reply	other threads:[~2008-02-25 22:37 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25 19:19 new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p Michael S. Tsirkin
2008-02-25 19:42 ` Alexey Starikovskiy
2008-02-25 20:39   ` Michael S. Tsirkin
2008-02-25 20:50     ` Alexey Starikovskiy
2008-02-25 21:01       ` Michael S. Tsirkin
2008-02-25 22:33         ` Alexey Starikovskiy
2008-02-25 23:18           ` Michael S. Tsirkin
2008-02-25 19:46 ` Andrew Morton
2008-02-25 20:39   ` Michael S. Tsirkin
2008-02-25 20:45   ` Michael S. Tsirkin
2008-02-25 20:57     ` broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p) Rafael J. Wysocki
2008-02-25 21:26       ` Pavel Machek
2008-02-25 21:31         ` Michael S. Tsirkin
2008-02-25 21:50           ` Pavel Machek
2008-02-25 22:15             ` Michael S. Tsirkin
2008-02-25 22:20               ` Pavel Machek
2008-02-25 22:36                 ` Michael S. Tsirkin [this message]
2008-02-25 22:39                   ` Andrew Morton
2008-02-25 22:48                     ` Michael S. Tsirkin
2008-02-25 22:53                       ` Andrew Morton
2008-02-25 22:58                         ` Michael S. Tsirkin
2008-02-25 22:58                         ` Pavel Machek
     [not found]                           ` <20080225155550.4a020dfb.akpm@linux-foundation.org>
     [not found]                             ` <20080226000007.GB22102@atrey.karlin.mff.cuni.cz>
2008-02-26 10:11                               ` Pavel Machek
2008-02-26 17:46                                 ` Dave Jones
2008-02-26 17:59                                   ` Pavel Machek
2008-02-26 18:10                                     ` Dave Jones
2008-02-26 18:16                                       ` Pavel Machek
2008-02-26 18:22                                         ` Dave Jones
2008-02-26 21:56                                           ` Pavel Machek
2008-02-26 22:23                                             ` Dave Jones
2008-02-26 22:31                                               ` Rafael J. Wysocki
2008-02-26 22:51                                               ` Pavel Machek
2008-02-27 13:12                                             ` Matthew Garrett
2008-02-27 13:23                                               ` Rafael J. Wysocki
2008-02-27 15:51                                                 ` Stefan Seyfried
2008-02-27 15:55                                                   ` Matthew Garrett
2008-02-26 18:56                                         ` Andrew Morton
2008-02-26 20:09                                           ` Len Brown
2008-02-26 23:31                                           ` Ray Lee
2008-02-27  0:12                                             ` Rafael J. Wysocki
2008-02-25 21:32         ` Jeff Garzik
2008-02-25 22:21           ` Pavel Machek
2008-02-26  8:54   ` new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p Klaus S. Madsen
2008-02-26 21:32     ` Klaus S. Madsen
2008-02-26 21:44       ` Jiri Kosina
2008-02-27 22:13         ` Klaus S. Madsen
2008-02-27 23:20           ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f53421d0802251436vd98a97h5db6b8af3dc39d0@mail.gmail.com \
    --to=m.s.tsirkin@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=astarikovskiy@suse.de \
    --cc=jeff@garzik.org \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --subject='Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).