LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alexey Khoroshilov <khoroshilov@ispras.ru>
To: Sebastian Reichel <sre@kernel.org>
Cc: Mike Looijmans <mike.looijmans@topic.nl>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	ldv-project@linuxtesting.org, Julia Lawall <julia.lawall@lip6.fr>,
	sil2review@lists.osadl.org
Subject: Re: [PATCH] power: supply: ltc2941-battery-gauge: Release device_node in ltc294x_i2c_probe()
Date: Tue, 8 May 2018 22:16:31 +0300	[thread overview]
Message-ID: <8fef316f-85d0-0bd4-4bbe-2d8330dfe2ec@ispras.ru> (raw)
In-Reply-To: <20180501123908.z3kuokp2b6umnnda@earth.universe>


Hi,

On 01.05.2018 15:39, Sebastian Reichel wrote:
> Hi,
> 
> On Sun, Apr 29, 2018 at 01:35:55AM +0300, Alexey Khoroshilov wrote:
>> There is of_node_get(client->dev.of_node) in ltc294x_i2c_probe(),
>> but these is no of_node_put() somethere in the driver.
>>
>> The patch adds one on error and normal paths.
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> 
> That is ugly. Let's replace of_property_read_u32(np, ...) with
> device_property_read_u32(dev, ...) and get rid of np instead.
> 

Ok, I will prepare v2.

What is the right way to replace
info->supply_desc.name = np->name;
?

If lifetime of 'client->dev.of_node' = 'np' cannot be less than lifetime
of 'client->dev', should we use just
info->supply_desc.name = client->dev.of_node->name;
?

Thank you,
Alexey

  reply	other threads:[~2018-05-08 19:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-28 22:35 Alexey Khoroshilov
2018-05-01 12:39 ` Sebastian Reichel
2018-05-08 19:16   ` Alexey Khoroshilov [this message]
2018-07-06 17:04     ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fef316f-85d0-0bd4-4bbe-2d8330dfe2ec@ispras.ru \
    --to=khoroshilov@ispras.ru \
    --cc=julia.lawall@lip6.fr \
    --cc=ldv-project@linuxtesting.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mike.looijmans@topic.nl \
    --cc=sil2review@lists.osadl.org \
    --cc=sre@kernel.org \
    --subject='Re: [PATCH] power: supply: ltc2941-battery-gauge: Release device_node in ltc294x_i2c_probe()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).