LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Tom Zanussi <tom.zanussi@linux.intel.com> To: rostedt@goodmis.org Cc: tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org, vedang.patel@intel.com, bigeasy@linutronix.de, joel.opensrc@gmail.com, joelaf@google.com, mathieu.desnoyers@efficios.com, baohong.liu@intel.com, rajvi.jingar@intel.com, julia@ni.com, fengguang.wu@intel.com, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, Tom Zanussi <tom.zanussi@linux.intel.com> Subject: [PATCH 2/4] tracing: Don't add flag strings when displaying variable references Date: Wed, 28 Mar 2018 15:10:54 -0500 [thread overview] Message-ID: <913318a5610ef6b24af2522575f671fa6ee19b6b.1522256721.git.tom.zanussi@linux.intel.com> (raw) In-Reply-To: <cover.1522256721.git.tom.zanussi@linux.intel.com> In-Reply-To: <cover.1522256721.git.tom.zanussi@linux.intel.com> Variable references should never have flags appended when displayed - prevent that from happening. Before: # cat /sys/kernel/debug/tracing/events/sched/sched_switch/trigger hist:keys=next_pid:vals=hitcount:wakeup_lat=common_timestamp.usecs-$ts0.usecs:... After: hist:keys=next_pid:vals=hitcount:wakeup_lat=common_timestamp.usecs-$ts0:... Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com> --- kernel/trace/trace_events_hist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index fb81447..468e43f 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -2052,7 +2052,7 @@ static void expr_field_str(struct hist_field *field, char *expr) strcat(expr, hist_field_name(field, 0)); - if (field->flags) { + if (field->flags && !(field->flags & HIST_FIELD_FL_VAR_REF)) { const char *flags_str = get_hist_field_flags(field); if (flags_str) { -- 1.9.3
next prev parent reply other threads:[~2018-03-28 20:11 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-28 20:10 [PATCH 0/4] tracing: A few inter-event bugfixes Tom Zanussi 2018-03-28 20:10 ` [PATCH 1/4] tracing: Fix display of hist trigger expressions containing timestamps Tom Zanussi 2018-03-28 20:10 ` Tom Zanussi [this message] 2018-03-28 20:10 ` [PATCH 3/4] tracing: Add action comparisons when testing matching hist triggers Tom Zanussi 2018-04-02 15:10 ` Masami Hiramatsu 2018-04-02 17:09 ` Tom Zanussi 2018-04-04 12:33 ` Masami Hiramatsu 2018-04-04 13:01 ` Steven Rostedt 2018-04-04 15:17 ` Tom Zanussi 2018-04-05 3:50 ` Masami Hiramatsu 2018-04-05 23:34 ` Tom Zanussi 2018-04-06 1:53 ` Masami Hiramatsu 2018-04-06 16:47 ` Tom Zanussi 2018-04-07 12:16 ` Masami Hiramatsu 2018-04-12 15:22 ` Tom Zanussi 2018-03-28 20:10 ` [PATCH 4/4] tracing: Make sure variable string fields are NULL-terminated Tom Zanussi 2018-04-02 15:26 ` [PATCH 0/4] tracing: A few inter-event bugfixes Steven Rostedt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=913318a5610ef6b24af2522575f671fa6ee19b6b.1522256721.git.tom.zanussi@linux.intel.com \ --to=tom.zanussi@linux.intel.com \ --cc=baohong.liu@intel.com \ --cc=bigeasy@linutronix.de \ --cc=fengguang.wu@intel.com \ --cc=joel.opensrc@gmail.com \ --cc=joelaf@google.com \ --cc=julia@ni.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rt-users@vger.kernel.org \ --cc=mathieu.desnoyers@efficios.com \ --cc=mhiramat@kernel.org \ --cc=namhyung@kernel.org \ --cc=rajvi.jingar@intel.com \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --cc=vedang.patel@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).