LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Casey Schaufler <casey@schaufler-ca.com>
To: David Howells <dhowells@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	jose.bollo@iot.bzh,
	Linux Security Module list 
	<linux-security-module@vger.kernel.org>,
	casey@schaufler-ca.com
Subject: Re: [PATCH] Smack: Restore the smackfsdef mount option
Date: Tue, 28 May 2019 08:51:24 -0700	[thread overview]
Message-ID: <9191ef31-a022-cdc4-9bed-ff225e4179bb@schaufler-ca.com> (raw)
In-Reply-To: <11440.1559046181@warthog.procyon.org.uk>

On 5/28/2019 5:23 AM, David Howells wrote:
> Casey Schaufler <casey@schaufler-ca.com> wrote:
>
>> The change was made in commit c3300aaf95fb4 from Al Viro.
> This should be in a "Fixes:" tag?

Thanks. I wasn't sure how to properly apply that.

>
>> +	fsparam_string("fsdef",		Opt_fsdefault),
>>  	fsparam_string("fsdefault",	Opt_fsdefault),
>>  	fsparam_string("fsfloor",	Opt_fsfloor),
>>  	fsparam_string("fshat",		Opt_fshat),
> Would it be better to delete the "fsdefault" line?

If it hadn't slipped into the 5.1 release I would
say to remove it, but now it would be a regression.

>
> Also, should all of these be prefixed with "smack"?  So:
>
>   	fsparam_string("smackfsdef",	Opt_fsdefault),
>   	fsparam_string("smackfsfloor",	Opt_fsfloor),
>   	fsparam_string("smackfshat",	Opt_fshat),	

No. smack_fs_parameters takes care of that.

>
> David


  reply	other threads:[~2019-05-28 15:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 22:48 Casey Schaufler
2019-05-21 22:25 ` Casey Schaufler
2019-05-28 12:23 ` David Howells
2019-05-28 15:51   ` Casey Schaufler [this message]
2019-05-28 16:22   ` David Howells
2019-05-28 16:41     ` Casey Schaufler
2019-05-28 18:54     ` David Howells
2019-05-28 19:57       ` Casey Schaufler
2019-05-28 20:24         ` Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9191ef31-a022-cdc4-9bed-ff225e4179bb@schaufler-ca.com \
    --to=casey@schaufler-ca.com \
    --cc=dhowells@redhat.com \
    --cc=jose.bollo@iot.bzh \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: [PATCH] Smack: Restore the smackfsdef mount option' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).