LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Muchun Song <songmuchun@bytedance.com>,
	akpm@linux-foundation.org, osalvador@suse.de, mhocko@suse.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: bootmem_info: mark __init on register_page_bootmem_info_section
Date: Tue, 17 Aug 2021 09:17:47 +0200	[thread overview]
Message-ID: <9198523b-a049-1c92-1818-989bab30628b@redhat.com> (raw)
In-Reply-To: <20210817042221.77172-1-songmuchun@bytedance.com>

On 17.08.21 06:22, Muchun Song wrote:
> The register_page_bootmem_info_section() is only called from __init
> functions, so mark __init on it as well.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
>   mm/bootmem_info.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/bootmem_info.c b/mm/bootmem_info.c
> index 5b152dba7344..f03f42f426f6 100644
> --- a/mm/bootmem_info.c
> +++ b/mm/bootmem_info.c
> @@ -39,7 +39,7 @@ void put_page_bootmem(struct page *page)
>   }
>   
>   #ifndef CONFIG_SPARSEMEM_VMEMMAP
> -static void register_page_bootmem_info_section(unsigned long start_pfn)
> +static void __init register_page_bootmem_info_section(unsigned long start_pfn)
>   {
>   	unsigned long mapsize, section_nr, i;
>   	struct mem_section *ms;
> @@ -74,7 +74,7 @@ static void register_page_bootmem_info_section(unsigned long start_pfn)
>   
>   }
>   #else /* CONFIG_SPARSEMEM_VMEMMAP */
> -static void register_page_bootmem_info_section(unsigned long start_pfn)
> +static void __init register_page_bootmem_info_section(unsigned long start_pfn)
>   {
>   	unsigned long mapsize, section_nr, i;
>   	struct mem_section *ms;
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb


      reply	other threads:[~2021-08-17  7:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17  4:22 Muchun Song
2021-08-17  7:17 ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9198523b-a049-1c92-1818-989bab30628b@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.de \
    --cc=songmuchun@bytedance.com \
    --subject='Re: [PATCH] mm: bootmem_info: mark __init on register_page_bootmem_info_section' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).