LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Kumar Gala <galak@codeaurora.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Alexandre Courbot <gnurou@gmail.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Discussions about the Letux Kernel <letux-kernel@openphoenux.org>,
	kernel@pyra-handheld.com
Subject: Re: [PATCH v5 0/7] pcal6524 extensions and fixes for pca953x driver
Date: Wed, 16 May 2018 16:37:23 +0200	[thread overview]
Message-ID: <9213FFC0-3C2B-447D-AA2C-55D7F93CFA27@goldelico.com> (raw)
In-Reply-To: <CACRpkda_nrL8HQL3y+tvHKff+5zKykd3Ym1waEm=JC1tFQbbcw@mail.gmail.com>


> Am 16.05.2018 um 16:31 schrieb Linus Walleij <linus.walleij@linaro.org>:
> 
> On Wed, May 16, 2018 at 3:32 PM, H. Nikolaus Schaller <hns@goldelico.com> wrote:
>>> Am 16.05.2018 um 13:53 schrieb Linus Walleij <linus.walleij@linaro.org>:
>>> On Sat, Apr 28, 2018 at 6:31 PM, H. Nikolaus Schaller <hns@goldelico.com> wrote:
>>> 
>>>> V5:
>>>> * fix wrong split up between patches 1/7and 2/7.
>>> 
>>> I applied patches 1, 2, 3 so we get some movement on the patch
>>> set and not too much for you to rebase.
>> 
>> thanks!
>> 
>> Well, I already had edited the commit messages for resending...
>> 
>>> 
>>> It's fine to just resend the rest next time.
>> 
>> There is only one point open before resending:
>> 
>> what is the preferred style to be used for PCAL_GPIO_MASK?
>> 
>> * GENMASK(4, 0)
>> * or 0x1f
> 
> No strong opinion... sorry. Whatever you & the other driver
> contributors are most convenient with.

Ok, then let's keep the GENMASK(4, 0) since nobody did complain
about it.

BR and thanks,
Nikolaus

      reply	other threads:[~2018-05-16 14:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-28 16:31 [PATCH v5 0/7] pcal6524 extensions and fixes for pca953x driver H. Nikolaus Schaller
2018-04-28 16:31 ` [PATCH v5 1/7] gpio: pca953x: convert register constants to hex H. Nikolaus Schaller
2018-05-16 11:49   ` Linus Walleij
2018-04-28 16:31 ` [PATCH v5 2/7] gpio: pca953x: add more register definitions for pcal953x H. Nikolaus Schaller
2018-05-16 11:51   ` Linus Walleij
2018-04-28 16:31 ` [PATCH v5 3/7] gpio: pca953x: add more register definitions for pcal6524 H. Nikolaus Schaller
2018-05-16 11:52   ` Linus Walleij
2018-04-28 16:31 ` [PATCH v5 4/7] gpio: pca953x: define masks for addressing common and extended registers H. Nikolaus Schaller
2018-05-02 12:29   ` Andy Shevchenko
2018-05-02 12:36     ` H. Nikolaus Schaller
2018-05-04  7:33       ` H. Nikolaus Schaller
2018-04-28 16:31 ` [PATCH v5 5/7] gpio: pca953x: fix address calculation for pcal6524 H. Nikolaus Schaller
2018-05-02 12:28   ` Andy Shevchenko
2018-05-02 12:35     ` H. Nikolaus Schaller
     [not found]       ` <14D3FF3C-0F70-4F72-B381-318B61B944CA@goldelico.com>
2018-05-05 10:29         ` Andy Shevchenko
2018-04-28 16:31 ` [PATCH v5 6/7] DTS: Bindings: pca953x add an optional vcc-supply property H. Nikolaus Schaller
2018-05-16 11:55   ` Linus Walleij
2018-04-28 16:31 ` [PATCH v5 7/7] DTS: Bindings: pca953x: add example how to use interrupt-controller and gpio-controller H. Nikolaus Schaller
2018-05-16 11:56   ` Linus Walleij
2018-05-02 11:53 ` [PATCH v5 0/7] pcal6524 extensions and fixes for pca953x driver Linus Walleij
2018-05-02 12:32 ` Andy Shevchenko
2018-05-16 11:53 ` Linus Walleij
2018-05-16 11:56   ` Linus Walleij
2018-05-16 13:32   ` H. Nikolaus Schaller
2018-05-16 14:31     ` Linus Walleij
2018-05-16 14:37       ` H. Nikolaus Schaller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9213FFC0-3C2B-447D-AA2C-55D7F93CFA27@goldelico.com \
    --to=hns@goldelico.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gnurou@gmail.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kernel@pyra-handheld.com \
    --cc=letux-kernel@openphoenux.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).