LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	linus.walleij@linaro.org, afaerber@suse.de, sfr@canb.auug.org.au
Cc: linux-next@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] pinctrl: actions: Fix Kconfig dependency and help text
Date: Mon, 30 Apr 2018 21:23:46 -0700	[thread overview]
Message-ID: <92d58976-7fe4-517e-95e9-b4255ecb390c@infradead.org> (raw)
In-Reply-To: <20180501030047.305-1-manivannan.sadhasivam@linaro.org>

On 04/30/2018 08:00 PM, Manivannan Sadhasivam wrote:
> 1. Fix Kconfig dependency for Actions Semi S900 pinctrl driver which
> generates below warning in x86:
> 
> WARNING: unmet direct dependencies detected for PINCTRL_OWL
>   Depends on [n]: PINCTRL [=y] && (ARCH_ACTIONS || COMPILE_TEST [=n]) && OF [=n]
>   Selected by [y]:
>   - PINCTRL_S900 [=y] && PINCTRL [=y]
> 
> 2. Add help text for OWL pinctrl driver
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/pinctrl/actions/Kconfig | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/actions/Kconfig b/drivers/pinctrl/actions/Kconfig
> index 1c7309c90f0d..ede97cdbbc12 100644
> --- a/drivers/pinctrl/actions/Kconfig
> +++ b/drivers/pinctrl/actions/Kconfig
> @@ -1,12 +1,14 @@
>  config PINCTRL_OWL
> -	bool
> +	bool "Actions Semi OWL pinctrl driver"
>  	depends on (ARCH_ACTIONS || COMPILE_TEST) && OF
>  	select PINMUX
>  	select PINCONF
>  	select GENERIC_PINCONF
> +	help
> +	  Say Y here to enable Actions Semi OWL pinctrl driver
>  
>  config PINCTRL_S900
>  	bool "Actions Semi S900 pinctrl driver"
> -	select PINCTRL_OWL
> +	depends on PINCTRL_OWL
>  	help
>  	  Say Y here to enable Actions Semi S900 pinctrl driver
> 


-- 
~Randy

  reply	other threads:[~2018-05-01  4:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01  3:00 Manivannan Sadhasivam
2018-05-01  4:23 ` Randy Dunlap [this message]
2018-05-02 11:49 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92d58976-7fe4-517e-95e9-b4255ecb390c@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=afaerber@suse.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=sfr@canb.auug.org.au \
    --subject='Re: [PATCH][next] pinctrl: actions: Fix Kconfig dependency and help text' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).