From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751641AbeCUGyK (ORCPT ); Wed, 21 Mar 2018 02:54:10 -0400 Received: from mleia.com ([178.79.152.223]:60656 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbeCUGyF (ORCPT ); Wed, 21 Mar 2018 02:54:05 -0400 Subject: Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup To: Peter Rosin , linux-kernel@vger.kernel.org Cc: Guenter Roeck , Wolfram Sang , Ken Chen , joel@jms.id.au, linux-i2c@vger.kernel.org References: <20180320061909.5775-1-chen.kenyy@inventec.com> <20180320093200.19179-1-peda@axentia.se> <20180320093200.19179-3-peda@axentia.se> From: Vladimir Zapolskiy Message-ID: <93631639-eefd-cd1c-48de-451662ce8de7@mleia.com> Date: Wed, 21 Mar 2018 08:54:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20180321_065404_543236_6ED3A6D6 X-CRM114-Status: GOOD ( 14.68 ) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On 03/21/2018 07:53 AM, Peter Rosin wrote: > On 2018-03-21 00:24, Vladimir Zapolskiy wrote: >> Hi Peter, >> >> On 03/20/2018 11:31 AM, Peter Rosin wrote: >>> In preparation for PCA9641 support, convert the mybus and busoff macros >>> to functions, and in the process prefix them with pca9541_. Also prefix >>> remaining chip specific macros with PCA9541_. >>> >>> Signed-off-by: Peter Rosin >>> --- >>> drivers/i2c/muxes/i2c-mux-pca9541.c | 26 +++++++++++++++++++------- >>> 1 file changed, 19 insertions(+), 7 deletions(-) >>> >>> diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c >>> index ad168125d23d..47685eb4e0e9 100644 >>> --- a/drivers/i2c/muxes/i2c-mux-pca9541.c >>> +++ b/drivers/i2c/muxes/i2c-mux-pca9541.c >>> @@ -59,10 +59,8 @@ >>> #define PCA9541_ISTAT_MYTEST BIT(6) >>> #define PCA9541_ISTAT_NMYTEST BIT(7) >>> >>> -#define BUSON (PCA9541_CTL_BUSON | PCA9541_CTL_NBUSON) >>> -#define MYBUS (PCA9541_CTL_MYBUS | PCA9541_CTL_NMYBUS) >>> -#define mybus(x) (!((x) & MYBUS) || ((x) & MYBUS) == MYBUS) >>> -#define busoff(x) (!((x) & BUSON) || ((x) & BUSON) == BUSON) >>> +#define PCA9541_BUSON (PCA9541_CTL_BUSON | PCA9541_CTL_NBUSON) >>> +#define PCA9541_MYBUS (PCA9541_CTL_MYBUS | PCA9541_CTL_NMYBUS) >>> >>> /* arbitration timeouts, in jiffies */ >>> #define ARB_TIMEOUT (HZ / 8) /* 125 ms until forcing bus ownership */ >>> @@ -93,6 +91,20 @@ static const struct of_device_id pca9541_of_match[] = { >>> MODULE_DEVICE_TABLE(of, pca9541_of_match); >>> #endif >>> >>> +static int pca9541_mybus(int ctl) >> >> static inline? > > No, "inline" is only used in header files in the kernel. No, it is an incorrect statement, you should be aware of that. > The compiler is free to inline whatever function it likes anyway, and > in this case we do not know better than the compiler. We don't care That's a candidate case, when we could know better than the compiler. But "don't care" argument is still valid :) -- With best wishes, Vladimir