LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: "Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
	"Juergen Gross" <jgross@suse.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Jens Axboe" <axboe@kernel.dk>,
	"David S. Miller" <davem@davemloft.net>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: [PATCH -next 020/491] XEN HYPERVISOR INTERFACE: Use fallthrough;
Date: Tue, 10 Mar 2020 21:51:34 -0700	[thread overview]
Message-ID: <93cb221f897e6d5d37539d9a8dcf8be7797bd401.1583896348.git.joe@perches.com> (raw)
In-Reply-To: <cover.1583896344.git.joe@perches.com>

Convert the various uses of fallthrough comments to fallthrough;

Done via script
Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/block/xen-blkfront.c               | 5 ++---
 drivers/net/xen-netfront.c                 | 2 +-
 drivers/pci/xen-pcifront.c                 | 2 +-
 drivers/scsi/xen-scsifront.c               | 2 +-
 drivers/xen/pvcalls-front.c                | 2 +-
 drivers/xen/xen-acpi-memhotplug.c          | 2 +-
 drivers/xen/xen-pciback/xenbus.c           | 2 +-
 drivers/xen/xen-scsiback.c                 | 2 +-
 drivers/xen/xenbus/xenbus_probe_frontend.c | 6 ++----
 9 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 9df516..fb07ee1 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -1402,7 +1402,6 @@ static enum blk_req_status blkif_rsp_to_req_status(int rsp)
 	case BLKIF_RSP_EOPNOTSUPP:
 		return REQ_EOPNOTSUPP;
 	case BLKIF_RSP_ERROR:
-		/* Fallthrough. */
 	default:
 		return REQ_ERROR;
 	}
@@ -1642,7 +1641,7 @@ static irqreturn_t blkif_interrupt(int irq, void *dev_id)
 				info->feature_flush = 0;
 				xlvbd_flush(info);
 			}
-			/* fall through */
+			fallthrough;
 		case BLKIF_OP_READ:
 		case BLKIF_OP_WRITE:
 			if (unlikely(bret->status != BLKIF_RSP_OKAY))
@@ -2480,7 +2479,7 @@ static void blkback_changed(struct xenbus_device *dev,
 	case XenbusStateClosed:
 		if (dev->state == XenbusStateClosed)
 			break;
-		/* fall through */
+		fallthrough;
 	case XenbusStateClosing:
 		if (info)
 			blkfront_closing(info);
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 482c6c..2001606 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -2038,7 +2038,7 @@ static void netback_changed(struct xenbus_device *dev,
 	case XenbusStateClosed:
 		if (dev->state == XenbusStateClosed)
 			break;
-		/* Fall through - Missed the backend's CLOSING state. */
+		fallthrough;	/* Missed the backend's CLOSING state */
 	case XenbusStateClosing:
 		xenbus_frontend_closed(dev);
 		break;
diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
index d1b16c..093ab8 100644
--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -1103,7 +1103,7 @@ static void __ref pcifront_backend_changed(struct xenbus_device *xdev,
 	case XenbusStateClosed:
 		if (xdev->state == XenbusStateClosed)
 			break;
-		/* fall through - Missed the backend's CLOSING state. */
+		fallthrough;	/* Missed the backend's CLOSING state */
 	case XenbusStateClosing:
 		dev_warn(&xdev->dev, "backend going away!\n");
 		pcifront_try_disconnect(pdev);
diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
index f0068e..259fc248 100644
--- a/drivers/scsi/xen-scsifront.c
+++ b/drivers/scsi/xen-scsifront.c
@@ -1111,7 +1111,7 @@ static void scsifront_backend_changed(struct xenbus_device *dev,
 	case XenbusStateClosed:
 		if (dev->state == XenbusStateClosed)
 			break;
-		/* fall through - Missed the backend's Closing state */
+		fallthrough;	/* Missed the backend's Closing state */
 	case XenbusStateClosing:
 		scsifront_disconnect(info);
 		break;
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 57592a6..0fccf0 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -1260,7 +1260,7 @@ static void pvcalls_front_changed(struct xenbus_device *dev,
 		if (dev->state == XenbusStateClosed)
 			break;
 		/* Missed the backend's CLOSING state */
-		/* fall through */
+		fallthrough;
 	case XenbusStateClosing:
 		xenbus_frontend_closed(dev);
 		break;
diff --git a/drivers/xen/xen-acpi-memhotplug.c b/drivers/xen/xen-acpi-memhotplug.c
index 745721..f914b72 100644
--- a/drivers/xen/xen-acpi-memhotplug.c
+++ b/drivers/xen/xen-acpi-memhotplug.c
@@ -229,7 +229,7 @@ static void acpi_memory_device_notify(acpi_handle handle, u32 event, void *data)
 	case ACPI_NOTIFY_BUS_CHECK:
 		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
 			"\nReceived BUS CHECK notification for device\n"));
-		/* Fall Through */
+		fallthrough;
 	case ACPI_NOTIFY_DEVICE_CHECK:
 		if (event == ACPI_NOTIFY_DEVICE_CHECK)
 			ACPI_DEBUG_PRINT((ACPI_DB_INFO,
diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
index 833b2d..a108740 100644
--- a/drivers/xen/xen-pciback/xenbus.c
+++ b/drivers/xen/xen-pciback/xenbus.c
@@ -544,7 +544,7 @@ static void xen_pcibk_frontend_changed(struct xenbus_device *xdev,
 		xenbus_switch_state(xdev, XenbusStateClosed);
 		if (xenbus_dev_is_online(xdev))
 			break;
-		/* fall through - if not online */
+		fallthrough;	/* if not online */
 	case XenbusStateUnknown:
 		dev_dbg(&xdev->dev, "frontend is gone! unregister device\n");
 		device_unregister(&xdev->dev);
diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c
index ba0942e..9daef2 100644
--- a/drivers/xen/xen-scsiback.c
+++ b/drivers/xen/xen-scsiback.c
@@ -1184,7 +1184,7 @@ static void scsiback_frontend_changed(struct xenbus_device *dev,
 		xenbus_switch_state(dev, XenbusStateClosed);
 		if (xenbus_dev_is_online(dev))
 			break;
-		/* fall through - if not online */
+		fallthrough;	/* if not online */
 	case XenbusStateUnknown:
 		device_unregister(&dev->dev);
 		break;
diff --git a/drivers/xen/xenbus/xenbus_probe_frontend.c b/drivers/xen/xenbus/xenbus_probe_frontend.c
index 8a1650..708917 100644
--- a/drivers/xen/xenbus/xenbus_probe_frontend.c
+++ b/drivers/xen/xenbus/xenbus_probe_frontend.c
@@ -402,13 +402,11 @@ static void xenbus_reset_frontend(char *fe, char *be, int be_state)
 	case XenbusStateConnected:
 		xenbus_printf(XBT_NIL, fe, "state", "%d", XenbusStateClosing);
 		xenbus_reset_wait_for_backend(be, XenbusStateClosing);
-		/* fall through */
-
+		fallthrough;
 	case XenbusStateClosing:
 		xenbus_printf(XBT_NIL, fe, "state", "%d", XenbusStateClosed);
 		xenbus_reset_wait_for_backend(be, XenbusStateClosed);
-		/* fall through */
-
+		fallthrough;
 	case XenbusStateClosed:
 		xenbus_printf(XBT_NIL, fe, "state", "%d", XenbusStateInitialising);
 		xenbus_reset_wait_for_backend(be, XenbusStateInitWait);
-- 
2.24.0


  parent reply	other threads:[~2020-03-11  5:07 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 17:24 [PATCH -next 000/491] treewide: use fallthrough; Joe Perches
2020-03-11  4:51 ` [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; Joe Perches
2020-03-11  7:01   ` Leon Romanovsky
2020-03-12  6:23   ` David Miller
2020-03-12  6:26     ` Joe Perches
2020-03-12  8:03       ` David Miller
2020-03-12 19:45       ` Jakub Kicinski
2020-03-12 19:52         ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 002/491] MARVELL OCTEONTX2 RVU ADMIN FUNCTION DRIVER: " Joe Perches
2020-03-11  4:51 ` [PATCH -next 003/491] MELLANOX MLX5 core VPI driver: " Joe Perches
2020-03-11  7:00   ` Leon Romanovsky
2020-03-11  4:51 ` [PATCH -next 004/491] PERFORMANCE EVENTS SUBSYSTEM: " Joe Perches
2020-03-11 15:30   ` Peter Zijlstra
2020-03-12  6:15     ` Joe Perches
2020-03-11 19:20   ` Thomas Bogendoerfer
2020-03-11  4:51 ` [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: " Joe Perches
2020-03-11  5:15   ` Masahiro Yamada
2020-03-11 14:31     ` Joe Perches
2020-03-12  8:56       ` Greg Kroah-Hartman
2020-03-12  9:02         ` Masahiro Yamada
2020-03-12  9:36           ` Greg Kroah-Hartman
2020-03-12  9:37           ` Joe Perches
2020-03-12 13:47             ` Theodore Y. Ts'o
2020-03-12 14:15               ` Joe Perches
2020-03-12  9:03         ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 006/491] ARM/RISCPC " Joe Perches
2020-03-12 10:11   ` Russell King - ARM Linux admin
2020-03-12 10:19     ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 007/491] KERNEL VIRTUAL MACHINE FOR ARM/ARM64 (KVM/arm, KVM/arm64): " Joe Perches
2020-03-11  4:51 ` [PATCH -next 008/491] ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: " Joe Perches
2020-03-13 19:26   ` Alexander Sverdlin
2020-03-11  4:51 ` [PATCH -next 009/491] ARM/Amlogic Meson SoC support: " Joe Perches
2020-03-11  4:51 ` [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: " Joe Perches
2020-03-13 14:26   ` Wolfram Sang
2020-03-14  1:17   ` Stephen Boyd
2020-05-13 11:59     ` Sylwester Nawrocki
2020-03-11  4:51 ` [PATCH -next 011/491] ARM/QUALCOMM SUPPORT: " Joe Perches
2020-03-11  5:23   ` Amit Kucheria
2020-03-11  8:46   ` Marc Gonzalez
2020-03-11 14:30     ` Joe Perches
2020-03-13 12:04   ` Stanimir Varbanov
2020-03-11  4:51 ` [PATCH -next 012/491] ARM/ZTE ARCHITECTURE: " Joe Perches
2020-03-11  4:51 ` [PATCH -next 013/491] INGENIC JZ47xx SoCs: " Joe Perches
2020-03-11  7:40   ` Miquel Raynal
2020-03-11 14:20     ` Ulf Hansson
2020-03-11 14:29       ` Miquel Raynal
2020-03-12  6:26     ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 014/491] DECSTATION PLATFORM SUPPORT: " Joe Perches
2020-03-11 19:19   ` Thomas Bogendoerfer
2020-03-11  4:51 ` [PATCH -next 015/491] KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips): " Joe Perches
2020-03-11 19:20   ` Thomas Bogendoerfer
2020-03-11  4:51 ` [PATCH -next 016/491] KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc): " Joe Perches
2020-03-19  1:18   ` Paul Mackerras
2020-03-19  1:22     ` Joe Perches
2020-03-19 23:33       ` Paul Mackerras
2020-03-11  4:51 ` [PATCH -next 017/491] CELL BROADBAND ENGINE ARCHITECTURE: " Joe Perches
2020-03-11  8:08   ` Arnd Bergmann
2020-03-26 12:06   ` Michael Ellerman
2020-03-11  4:51 ` [PATCH -next 018/491] KERNEL VIRTUAL MACHINE for s390 (KVM/s390): " Joe Perches
2020-03-11 11:33   ` Christian Borntraeger
2020-03-13 12:04   ` Christian Borntraeger
2020-03-11  4:51 ` [PATCH -next 019/491] Hyper-V CORE AND DRIVERS: " Joe Perches
2020-03-11 11:00   ` Wei Liu
2020-03-11  4:51 ` Joe Perches [this message]
2020-03-11  6:47   ` [PATCH -next 020/491] XEN HYPERVISOR INTERFACE: " Jürgen Groß
2020-03-11  4:51 ` [PATCH -next 021/491] KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86): " Joe Perches
2020-03-11  9:43   ` Paolo Bonzini
2020-03-11  4:51 ` [PATCH -next 022/491] X86 MCE INFRASTRUCTURE: " Joe Perches
2020-03-11 17:14   ` Borislav Petkov
2020-03-11  4:51 ` [PATCH -next 023/491] AMD KFD: " Joe Perches
2020-03-11 21:50   ` Felix Kuehling
2020-03-11 22:09     ` Joe Perches
2020-03-12 14:12       ` Alex Deucher
2020-03-11  4:51 ` [PATCH -next 024/491] AMD DISPLAY CORE: " Joe Perches
2020-03-12 14:10   ` Alex Deucher
2020-03-11  4:51 ` [PATCH -next 025/491] AMD POWERPLAY: " Joe Perches
2020-03-12 14:10   ` Alex Deucher
2020-03-11  4:51 ` [PATCH -next 026/491] INTEL GVT-g DRIVERS (Intel GPU Virtualization): " Joe Perches
2020-03-11  4:51 ` [PATCH -next 027/491] AMD XGBE DRIVER: " Joe Perches
2020-03-11  4:51 ` [PATCH -next 028/491] BROADCOM BNX2X 10 GIGABIT ETHERNET " Joe Perches
2020-03-11  4:51 ` [PATCH -next 029/491] BROADCOM BNXT_EN 50 " Joe Perches
2020-03-11  4:51 ` [PATCH -next 030/491] BROADCOM GENET " Joe Perches
2020-03-11 16:35   ` Florian Fainelli
2020-03-11  4:51 ` [PATCH -next 031/491] BROCADE BNA 10 GIGABIT " Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93cb221f897e6d5d37539d9a8dcf8be7797bd401.1583896348.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=axboe@kernel.dk \
    --cc=bhelgaas@google.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=davem@davemloft.net \
    --cc=jejb@linux.ibm.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=netdev@vger.kernel.org \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH -next 020/491] XEN HYPERVISOR INTERFACE: Use fallthrough;' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).