LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ben Gardon <bgardon@google.com>
Subject: Re: [PATCH v2 0/2] KVM: x86/mmu: Fix a TDP MMU leak and optimize zap all
Date: Fri, 13 Aug 2021 09:36:21 +0200	[thread overview]
Message-ID: <93efa388-ed99-f6b4-4a2b-352632aa8a18@redhat.com> (raw)
In-Reply-To: <20210812181414.3376143-1-seanjc@google.com>

On 12/08/21 20:14, Sean Christopherson wrote:
> Patch 1 fixes a leak of root-1 shadow pages, patch 2 is a minor
> optimization to the zap all flow that avoids re-reading and re-checking
> the root-1 SPTEs after they've been zapped by "zap all" flows.
> 
> I'm still somewhat on the fence for patch 2, feel free to drop it.
> 
> v2:
>   - Replaced magic number silliness with Paolo's much more clever suggestion.
>   - Elaborated on the benefits of the optimization.
>   - Add Ben's somewhat reluctant review for the optimization.
> 
> v1: https://lkml.kernel.org/r/20210812050717.3176478-1-seanjc@google.com
> 
> Sean Christopherson (2):
>    KVM: x86/mmu: Don't leak non-leaf SPTEs when zapping all SPTEs
>    KVM: x86/mmu: Don't step down in the TDP iterator when zapping all
>      SPTEs
> 
>   arch/x86/kvm/mmu/tdp_mmu.c | 35 ++++++++++++++++++++++++-----------
>   1 file changed, 24 insertions(+), 11 deletions(-)
> 

Queued, thanks.

Paolo


      parent reply	other threads:[~2021-08-13  7:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12 18:14 Sean Christopherson
2021-08-12 18:14 ` [PATCH v2 1/2] KVM: x86/mmu: Don't leak non-leaf SPTEs when zapping all SPTEs Sean Christopherson
2021-08-12 18:14 ` [PATCH v2 2/2] KVM: x86/mmu: Don't step down in the TDP iterator " Sean Christopherson
2021-08-13  7:36 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93efa388-ed99-f6b4-4a2b-352632aa8a18@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=bgardon@google.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seanjc@google.com \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --subject='Re: [PATCH v2 0/2] KVM: x86/mmu: Fix a TDP MMU leak and optimize zap all' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).