LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Luben Tuikov <ltuikov@yahoo.com>
To: James.Bottomley@HansenPartnership.com,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] scsi_error: Fix language abuse.
Date: Sat, 9 Feb 2008 00:02:33 -0800 (PST)	[thread overview]
Message-ID: <949768.13992.qm@web31801.mail.mud.yahoo.com> (raw)
In-Reply-To: <20080208153217.5fc42a50@core>

--- On Fri, 2/8/08, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> The word "illegal" has a precise dictionary
> meaning of "prohibited by
> law". The error messages are therefore incorrect as so
> far nobody has
> made SCSI violations a criminal offence.
> 
> This corrects scsi to match various other subsystems
> I've slowly been
> ridding of this.
> 
> Pedantically-signed-off-by: Alan Cox
> <alan@redhat.com>

Alan,

In standards and in hardware specs, from which the meaning of
"illegal" is borrowed from (into standards), "illegal" doesn't
necessarily mean "invalid", and cannot be substituted for.
This is exactly why this particular word is used in the ASC/ASCQ
assignments.  It exposes an underlying behaviour.

For example:

> -	{0x2004, "Illegal command while in write capable state"},
> +	{0x2004, "Invalid command while in write capable state"},

Consider this: the command itself can be very perfectly "valid",
e.g. the SCB contents, format, etc., but certainly "illegal".

Similarly for the rest of this patch.

   Luben


      parent reply	other threads:[~2008-02-09  8:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08 15:32 Alan Cox
2008-02-08 15:57 ` James Bottomley
2008-02-08 15:59   ` Alan Cox
2008-02-08 16:28     ` James Bottomley
2008-02-08 16:07   ` linux-os (Dick Johnson)
2008-02-08 16:27     ` Mark Hounschell
2008-02-11 16:07       ` linux-os (Dick Johnson)
2008-02-11 17:13         ` Benny Halevy
2008-02-09  1:32 ` Douglas Gilbert
2008-02-09 13:50   ` Alan Cox
2008-02-10 23:24     ` Douglas Gilbert
2008-02-10 23:47     ` Matthew Wilcox
2008-02-09  8:02 ` Luben Tuikov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=949768.13992.qm@web31801.mail.mud.yahoo.com \
    --to=ltuikov@yahoo.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --subject='Re: [PATCH] scsi_error: Fix language abuse.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).