LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Greg KH' <gregkh@linuxfoundation.org>,
"richard.gong@linux.intel.com" <richard.gong@linux.intel.com>
Cc: "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"dinguyen@kernel.org" <dinguyen@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"atull@kernel.org" <atull@kernel.org>,
"mdf@kernel.org" <mdf@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
"yves.vandervennet@linux.intel.com"
<yves.vandervennet@linux.intel.com>,
"richard.gong@intel.com" <richard.gong@intel.com>
Subject: RE: [PATCHv3 3/7] driver, misc: add Intel Stratix10 service layer driver
Date: Tue, 24 Apr 2018 11:24:52 +0000 [thread overview]
Message-ID: <9498165854b84321801d8186d3040b1e@AcuMS.aculab.com> (raw)
In-Reply-To: <20180423120300.GC7951@kroah.com>
From: Greg KH
> Sent: 23 April 2018 13:03
> On Tue, Mar 27, 2018 at 03:20:10PM -0500, richard.gong@linux.intel.com wrote:
> > +config INTEL_SERVICE
>
> Naming is hard, but this is a _very_ generic name, don't you agree?
>
> > + tristate "Intel Service Layer"
>
> As is this. Can you make this a bit more specific to what hardware is
> being controlled here?
>
> > +++ b/drivers/misc/intel-service.c
>
> Same for the file name, why not stratix10.c?
>
> or intel_svc.c? That makes it a _bit_ more generic. Well, not really,
> but it does hide the "genericness" a bit more, right?
It'll all be even worse if (when) Intel decide to sell Altera to
someone else.
David
next prev parent reply other threads:[~2018-04-24 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 20:20 [PATCHv3 0/7] Add Intel Stratix10 FPGA manager and service layer richard.gong
2018-03-27 20:20 ` [PATCHv3 1/7] dt-bindings, firmware: add Intel Stratix10 service layer binding richard.gong
2018-04-05 13:16 ` Rob Herring
2018-03-27 20:20 ` [PATCHv3 2/7] arm64: dts: stratix10: add service driver binding to base dtsi richard.gong
2018-03-27 20:20 ` [PATCHv3 3/7] driver, misc: add Intel Stratix10 service layer driver richard.gong
2018-04-23 12:03 ` Greg KH
2018-04-24 11:24 ` David Laight [this message]
2018-03-27 20:20 ` [PATCHv3 4/7] dt-bindings: fpga: add Stratix10 SoC FPGA manager binding richard.gong
2018-03-29 21:12 ` Alan Tull
2018-03-27 20:20 ` [PATCHv3 5/7] arm64: dts: stratix10: add fpga manager and region richard.gong
2018-03-27 20:20 ` [PATCHv3 6/7] fpga: add intel stratix10 soc fpga manager driver richard.gong
2018-03-27 20:20 ` [PATCHv3 7/7] defconfig: enable fpga and service layer richard.gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9498165854b84321801d8186d3040b1e@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=arnd@arndb.de \
--cc=atull@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=richard.gong@intel.com \
--cc=richard.gong@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
--cc=yves.vandervennet@linux.intel.com \
--subject='RE: [PATCHv3 3/7] driver, misc: add Intel Stratix10 service layer driver' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).