LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Tianxing Zhang <anakinzhang96@gmail.com>
Cc: linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ima: check control characters in policy file path
Date: Tue, 17 Aug 2021 13:45:28 -0400	[thread overview]
Message-ID: <94c4f4c6544035b0114c4fd4bcfabae1551b6304.camel@linux.ibm.com> (raw)
In-Reply-To: <20210814082723.261-1-anakinzhang96@gmail.com>

On Sat, 2021-08-14 at 16:27 +0800, Tianxing Zhang wrote:
> When a policy file path contains control characters like '\r' or '\b',
> invalid error messages can be printed to overwrite system messages:
> 
> $ echo -e "/\rtest 12345678" > /sys/kernel/security/ima/policy
> 
> This patch rejects policy paths with control characters.
> 
> Signed-off-by: Tianxing Zhang <anakinzhang96@gmail.com>
> ---
>  security/integrity/ima/ima_fs.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/security/integrity/ima/ima_fs.c b/security/integrity/ima/ima_fs.c
> index 3d8e9d5db5aa..e6daa138de89 100644
> --- a/security/integrity/ima/ima_fs.c
> +++ b/security/integrity/ima/ima_fs.c
> @@ -316,6 +316,7 @@ static ssize_t ima_write_policy(struct file *file, const char __user *buf,
>  {
>  	char *data;
>  	ssize_t result;
> +	int i;
>  
>  	if (datalen >= PAGE_SIZE)
>  		datalen = PAGE_SIZE - 1;
> @@ -331,6 +332,14 @@ static ssize_t ima_write_policy(struct file *file, const char __user *buf,
>  		goto out;
>  	}
>  
> +	for (i = 0; data[i] != '\n' && data[i] != '\0'; i++) {
> +		if (iscntrl(data[i])) {
> +			pr_err_once("file path with no control characters required\n");
> +			result = -EINVAL;
> +			goto out_free;
> +		}
> +	}
> +
>  	result = mutex_lock_interruptible(&ima_write_mutex);
>  	if (result < 0)
>  		goto out_free;

The IMA audit messages already display pathnames via
audit_log_untrustedstring().  Shouldn't any change be limited to the
ima_policy_read() code path?

thanks,

Mimi


      reply	other threads:[~2021-08-17 17:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-14  8:27 Tianxing Zhang
2021-08-17 17:45 ` Mimi Zohar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94c4f4c6544035b0114c4fd4bcfabae1551b6304.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=anakinzhang96@gmail.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --subject='Re: [PATCH 1/1] ima: check control characters in policy file path' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).