LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Riccardo Mancini <rickyman7@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Ian Rogers <irogers@google.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@redhat.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [RFC PATCH 02/10] perf tests: add test for workqueue
Date: Thu, 15 Jul 2021 18:33:29 +0200	[thread overview]
Message-ID: <959c58526c5388eb891fd8a5927b5abc08c46a58.camel@gmail.com> (raw)
In-Reply-To: <YO7+g3wvtvJ+Zm5o@kernel.org>

Hi Arnaldo,

On Wed, 2021-07-14 at 12:10 -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jul 13, 2021 at 02:11:13PM +0200, Riccardo Mancini escreveu:
> > It will have subtests testing threadpool and workqueue separately.
> > This patch only introduces the first subtest, checking that the
> > threadpool is correctly created and destructed.
> > This test will be expanded when new functions are added in next
> > patches.
> > 
> > Signed-off-by: Riccardo Mancini <rickyman7@gmail.com>
<SNIP>
> > +
> > +
> > +static int __test__threadpool(void *_args)
> > +{
> > +       struct threadpool_test_args_t *args = _args;
> > +       struct threadpool_struct *pool;
> > +       int ret;
> > +
> > +       ret = __threadpool__prepare(&pool, args->pool_size);
> 
> Turn the last three lines into one;

ok

> 
>         int ret = __threadpool__prepare(&pool, args->pool_size);
> 
> > +       if (ret)
> > +               return ret;
> > +
> > +       ret = __threadpool__teardown(pool);
> > +       if (ret)
> > +               return ret;
> > +
> > +       return 0;
> 
> Humm, will you add something here in the following csets? Otherwise turn
> these 5 lines into one:
> 
>         return __threadpool__teardown(pool);

ok, it was just copy-paste from above.

Thanks,
Riccardo

> 
> > +}
> > +
> > +static const struct threadpool_test_args_t threadpool_test_args[] = {
> > +       {
> > +               .pool_size = 1
> > +       },
> > +       {
> > +               .pool_size = 2
> > +       },
> > +       {
> > +               .pool_size = 4
> > +       },
> > +       {
> > +               .pool_size = 8
> > +       },
> > +       {
> > +               .pool_size = 16
> > +       }
> > +};
> > +
> > +struct test_case {
> > +       const char *desc;
> > +       int (*func)(void *args);
> > +       void *args;
> > +       int n_args;
> > +       int arg_size;
> > +};
> > +
> > +static struct test_case workqueue_testcase_table[] = {
> > +       {
> > +               .desc = "Threadpool",
> > +               .func = __test__threadpool,
> > +               .args = (void *) threadpool_test_args,
> > +               .n_args = (int)ARRAY_SIZE(threadpool_test_args),
> > +               .arg_size = sizeof(struct threadpool_test_args_t)
> > +       }
> > +};
> > +
> > +
> > +int test__workqueue(struct test *test __maybe_unused, int i)
> > +{
> > +       int j, ret = 0;
> > +       struct test_case *tc;
> > +
> > +       if (i < 0 || i >= (int)ARRAY_SIZE(workqueue_testcase_table))
> > +               return -1;
> > +
> > +       tc = &workqueue_testcase_table[i];
> > +
> > +       for (j = 0; j < tc->n_args; j++) {
> > +               ret = tc->func(tc->args + (j*tc->arg_size));
> > +               if (ret)
> > +                       return ret;
> > +       }
> > +
> > +       return 0;
> > +}
> > +
> > +
> > +int test__workqueue_subtest_get_nr(void)
> > +{
> > +       return (int)ARRAY_SIZE(workqueue_testcase_table);
> > +}
> > +
> > +const char *test__workqueue_subtest_get_desc(int i)
> > +{
> > +       if (i < 0 || i >= (int)ARRAY_SIZE(workqueue_testcase_table))
> > +               return NULL;
> > +       return workqueue_testcase_table[i].desc;
> > +}
> > -- 
> > 2.31.1
> > 
> 



  reply	other threads:[~2021-07-15 16:33 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13 12:11 [RFC PATCH 00/10] perf: add workqueue library and use it in synthetic-events Riccardo Mancini
2021-07-13 12:11 ` [RFC PATCH 01/10] perf workqueue: threadpool creation and destruction Riccardo Mancini
2021-07-14 14:16   ` Arnaldo Carvalho de Melo
2021-07-15 16:31     ` Riccardo Mancini
2021-07-15 20:48       ` Arnaldo Carvalho de Melo
2021-07-15 23:29     ` Namhyung Kim
2021-07-16 13:36       ` Riccardo Mancini
2021-07-19 19:39         ` Namhyung Kim
2021-07-13 12:11 ` [RFC PATCH 02/10] perf tests: add test for workqueue Riccardo Mancini
2021-07-14 15:10   ` Arnaldo Carvalho de Melo
2021-07-15 16:33     ` Riccardo Mancini [this message]
2021-07-13 12:11 ` [RFC PATCH 03/10] perf workqueue: add threadpool start and stop functions Riccardo Mancini
2021-07-14 15:15   ` Arnaldo Carvalho de Melo
2021-07-15 16:42     ` Riccardo Mancini
2021-07-15 20:43       ` Arnaldo Carvalho de Melo
2021-07-15 23:48   ` Namhyung Kim
2021-07-16 13:53     ` Riccardo Mancini
2021-07-16 16:29       ` Arnaldo Carvalho de Melo
2021-07-13 12:11 ` [RFC PATCH 04/10] perf workqueue: add threadpool execute and wait functions Riccardo Mancini
2021-07-15 23:56   ` Namhyung Kim
2021-07-16 13:55     ` Riccardo Mancini
2021-07-13 12:11 ` [RFC PATCH 05/10] perf workqueue: add sparse annotation header Riccardo Mancini
2021-07-13 12:11 ` [RFC PATCH 06/10] perf workqueue: introduce workqueue struct Riccardo Mancini
2021-07-14 15:22   ` Arnaldo Carvalho de Melo
2021-07-15 16:49     ` Riccardo Mancini
2021-07-15 20:47       ` Arnaldo Carvalho de Melo
2021-07-13 12:11 ` [RFC PATCH 07/10] perf workqueue: implement worker thread and management Riccardo Mancini
2021-07-13 12:11 ` [RFC PATCH 08/10] perf workqueue: add queue_work and flush_workqueue functions Riccardo Mancini
2021-07-13 12:11 ` [RFC PATCH 09/10] perf workqueue: add utility to execute a for loop in parallel Riccardo Mancini
2021-07-13 12:11 ` [RFC PATCH 10/10] perf synthetic-events: use workqueue parallel_for Riccardo Mancini
2021-07-13 19:14 ` [RFC PATCH 00/10] perf: add workqueue library and use it in synthetic-events Arnaldo Carvalho de Melo
2021-07-19 21:13 ` Jiri Olsa
2021-07-22 16:15   ` Riccardo Mancini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=959c58526c5388eb891fd8a5927b5abc08c46a58.camel@gmail.com \
    --to=rickyman7@gmail.com \
    --cc=arnaldo.melo@gmail.com \
    --cc=irogers@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --subject='Re: [RFC PATCH 02/10] perf tests: add test for workqueue' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).