LKML Archive on
help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: "'Ard Biesheuvel'" <>,
	Hans de Goede <>
Cc: Thomas Gleixner <>,
	Ingo Molnar <>, "H . Peter Anvin" <>,
	the arch/x86 maintainers <>,
	"" <>,
	"Linux Kernel Mailing List" <>
Subject: RE: [PATCH v2] efi: Ignore unrealistically large option roms
Date: Tue, 1 May 2018 13:52:55 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

From: Ard Biesheuvel
> Sent: 28 April 2018 07:41
> On 27 April 2018 at 23:35, Hans de Goede <> wrote:
> > setup_efi_pci() tries to save a copy of each PCI option ROM as this may
> > be necessary for the device driver for the PCI device to have access too.
> >
> > On some systems the efi_pci_io_protocol_64's romimage and romsize fields
> > contain invalid data, which looks a bit like pointers pointing back into
> > other EFI code or data. Interpreting these pointers as romsize leads to
> > a very large value and if we then try to alloc this amount of memory to
> > save a copy the alloc call fails.
> >
> > This leads to a "Failed to alloc mem for rom" error being printed on the
> > EFI console for each PCI device.
> >
> > This commit avoids the printing of these errors, by checking romsize
> > before doing the alloc and if it is larger then 256M silently ignore the
> > ROM fields instead of trying to alloc mem and fail.
> >
> The UEFI spec limits the size of option ROMs to 16 MiB, so I'd prefer
> we use that as the upper bound instead.

Copying even 16MB of rom data into physical memory on the 'off chance' that
the kernel might need it seems a waste of memory.

I can't help feeling that some kind of caching would be more appropriate.


  parent reply	other threads:[~2018-05-01 13:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 21:35 Hans de Goede
2018-04-28  6:40 ` Ard Biesheuvel
2018-04-28 20:11   ` Hans de Goede
2018-05-01 13:52   ` David Laight [this message]
2018-05-01 13:57     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='RE: [PATCH v2] efi: Ignore unrealistically large option roms' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).