LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: linux-kernel@vger.kernel.org, monstr@monstr.eu,
	michal.simek@xilinx.com, git@xilinx.com, maz@kernel.org
Cc: Stefan Asserhall <stefan.asserhall@xilinx.com>,
	Jason Cooper <jason@lakedaemon.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] irqchip: xilinx: Fill error code when irq domain registration fails
Date: Mon, 24 Feb 2020 13:05:13 +0100	[thread overview]
Message-ID: <968acd4ba3a053554b17da93aaa1cead3c00c5f3.1582545908.git.michal.simek@xilinx.com> (raw)
In-Reply-To: <cover.1582545908.git.michal.simek@xilinx.com>

There is no ret filled in case of irq_domain_add_linear() failure.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Stefan Asserhall <stefan.asserhall@xilinx.com>
---

Changes in v2: None

 drivers/irqchip/irq-xilinx-intc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-xilinx-intc.c b/drivers/irqchip/irq-xilinx-intc.c
index 51f461d2934f..cf1bb470d7b5 100644
--- a/drivers/irqchip/irq-xilinx-intc.c
+++ b/drivers/irqchip/irq-xilinx-intc.c
@@ -230,6 +230,7 @@ static int __init xilinx_intc_of_init(struct device_node *intc,
 						  &xintc_irq_domain_ops, irqc);
 	if (!irqc->root_domain) {
 		pr_err("irq-xilinx: Unable to create IRQ domain\n");
+		ret = -EINVAL;
 		goto error;
 	}
 
-- 
2.25.1


  reply	other threads:[~2020-02-24 12:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24 12:05 [PATCH v2 0/2] irqchip: xilinx: Switch to generic domain handler Michal Simek
2020-02-24 12:05 ` Michal Simek [this message]
2020-02-24 12:05 ` [PATCH v2 2/2] irqchip: xilinx: Enable generic irq multi handler Michal Simek
2020-03-08 14:01 ` [PATCH v2 0/2] irqchip: xilinx: Switch to generic domain handler Marc Zyngier
2020-03-08 14:32   ` Marc Zyngier
2020-03-09  8:20     ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=968acd4ba3a053554b17da93aaa1cead3c00c5f3.1582545908.git.michal.simek@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=git@xilinx.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=monstr@monstr.eu \
    --cc=stefan.asserhall@xilinx.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH v2 1/2] irqchip: xilinx: Fill error code when irq domain registration fails' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).