From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B8CBC2BB1D for ; Thu, 12 Mar 2020 06:27:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0671B20650 for ; Thu, 12 Mar 2020 06:27:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387885AbgCLG1w (ORCPT ); Thu, 12 Mar 2020 02:27:52 -0400 Received: from smtprelay0080.hostedemail.com ([216.40.44.80]:44926 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387784AbgCLG1v (ORCPT ); Thu, 12 Mar 2020 02:27:51 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 72080182CED5B; Thu, 12 Mar 2020 06:27:50 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: point06_441a962f90223 X-Filterd-Recvd-Size: 3157 Received: from XPS-9350.home (unknown [47.151.143.254]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Thu, 12 Mar 2020 06:27:47 +0000 (UTC) Message-ID: <969ea500cfd66fa2fc32e8d1e9c6126710d16813.camel@perches.com> Subject: Re: [PATCH -next 013/491] INGENIC JZ47xx SoCs: Use fallthrough; From: Joe Perches To: Miquel Raynal Cc: Paul Cercueil , Harvey Hunt , David Airlie , Daniel Vetter , Ulf Hansson , Richard Weinberger , Vignesh Raghavendra , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, alsa-devel@alsa-project.org Date: Wed, 11 Mar 2020 23:26:04 -0700 In-Reply-To: <20200311084052.3ca3c331@xps13> References: <20200311084052.3ca3c331@xps13> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-03-11 at 08:40 +0100, Miquel Raynal wrote: > Hi Joe, > > Joe Perches wrote on Tue, 10 Mar 2020 21:51:27 -0700: > > > Convert the various uses of fallthrough comments to fallthrough; > > > > Done via script > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > > > Signed-off-by: Joe Perches > > --- > > drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +- > > drivers/mmc/host/jz4740_mmc.c | 6 ++---- > > drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +- > > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c | 4 ++-- > > drivers/mtd/nand/raw/ingenic/jz4780_bch.c | 4 ++-- > > sound/soc/codecs/jz4770.c | 2 +- > > 6 files changed, 9 insertions(+), 11 deletions(-) > > I like very much the new way to advertise for fallthrough statements, > but I am not willing to take any patch converting a single driver > anymore. I had too many from Gustavo when these comments had to be > inserted. I would really prefer a MTD-wide or a NAND-wide or at least a > raw-NAND-wide single patch (anything inside drivers/mtd/nand/raw/). I understand completely. This set was done to generate patches by nominally maintained subsystems. If you want something else: The easiest thing for you to do would be to run the cvt_fallthrough.pl script yourself. $ cvt_fallthrough.pl drivers/mtd/nand/raw/ That would produce: $ git diff --shortstat drivers/mtd/nand/raw 9 files changed, 18 insertions(+), 24 deletions(-) or $ cvt_fallthrough.pl drivers/mtd/ which would produce: $ git diff --shortstat drivers/mtd/ 22 files changed, 45 insertions(+), 60 deletions(-) cheers, Joe