LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Yang, Bo" <Bo.Yang@lsi.com>
To: "James Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: "Matthew Wilcox" <matthew@wil.cx>, <linux-scsi@vger.kernel.org>,
	<akpm@osdl.org>, <linux-kernel@vger.kernel.org>,
	"Patro, Sumant" <Sumant.Patro@lsi.com>,
	"Kolli, Neela" <Neela.Kolli@lsi.com>
Subject: RE: [PATCH 1/1] scsi: megaraid_sas - Fix random failure of DCDBcmds with sense info
Date: Mon, 25 Feb 2008 14:30:19 -0700	[thread overview]
Message-ID: <9738BCBE884FDB42801FAD8A7769C26501F69BBB@NAMAIL1.ad.lsil.com> (raw)
In-Reply-To: <1203698131.6206.22.camel@localhost.localdomain>

James,

Thanks for the reply.  We will resubmit the patch to rollback it to our
original implementation.

Regards.

Bo Yang

-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com] 
Sent: Friday, February 22, 2008 11:36 AM
To: Yang, Bo
Cc: Matthew Wilcox; linux-scsi@vger.kernel.org; akpm@osdl.org;
linux-kernel@vger.kernel.org; Patro, Sumant; Kolli, Neela
Subject: RE: [PATCH 1/1] scsi: megaraid_sas - Fix random failure of
DCDBcmds with sense info


On Fri, 2008-02-22 at 09:17 -0700, Yang, Bo wrote:
> James,
> 
> What is the status for this patch?  We need to submit more patches 
> based on the acceptance of this patch.

OK, read the thread; Matthew is right.  What you propose would pretty
much destroy compat ioctl handling within the driver.  You need a compat
handler for MEGASAS_IOC_FW.

With your current patch you'd get a failure both from a 64 bit binary
running on x86-64 and if someone ran the x86 binary on ia64.

The driver already uses the compat infrastructure, it shouldn't be too
hard to add this in the correct manner.

James



      reply	other threads:[~2008-02-25 21:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-22 16:17 [PATCH 1/1] scsi: megaraid_sas - Fix random failure of DCDB cmds " Yang, Bo
2008-02-22 16:24 ` Matthew Wilcox
2008-02-22 16:27 ` James Bottomley
2008-02-22 16:35 ` James Bottomley
2008-02-25 21:30   ` Yang, Bo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9738BCBE884FDB42801FAD8A7769C26501F69BBB@NAMAIL1.ad.lsil.com \
    --to=bo.yang@lsi.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=Neela.Kolli@lsi.com \
    --cc=Sumant.Patro@lsi.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --subject='RE: [PATCH 1/1] scsi: megaraid_sas - Fix random failure of DCDBcmds with sense info' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).