LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Jonas Dreßler" <verdre@v0yd.nl>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Amitkumar Karwar" <amitkarwar@gmail.com>,
	"Ganapathi Bhat" <ganapathi017@gmail.com>,
	"Xinming Hu" <huxinming820@gmail.com>,
	"Kalle Valo" <kvalo@codeaurora.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Tsuchiya Yuto" <kitakar@gmail.com>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	"Maximilian Luz" <luzmaximilian@gmail.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Pali Rohár" <pali@kernel.org>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Johannes Berg" <johannes@sipsolutions.net>,
	"Brian Norris" <briannorris@chromium.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mwifiex: Try waking the firmware until we get an interrupt
Date: Thu, 30 Sep 2021 23:07:09 +0200	[thread overview]
Message-ID: <98c1b772-ae6b-e435-030e-399f613061ba@v0yd.nl> (raw)
In-Reply-To: <YVYk/1+ftFUOoitF@smile.fi.intel.com>

On 9/30/21 10:58 PM, Andy Shevchenko wrote:
> On Thu, Sep 30, 2021 at 08:04:00PM +0200, Jonas Dreßler wrote:
>> On 9/22/21 1:19 PM, Andy Shevchenko wrote:
>>> On Tue, Sep 14, 2021 at 01:48:13PM +0200, Jonas Dreßler wrote:
> 
> ...
> 
>>>> +	do {
>>>> +		if (mwifiex_write_reg(adapter, reg->fw_status, FIRMWARE_READY_PCIE)) {
>>>> +			mwifiex_dbg(adapter, ERROR,
>>>> +				    "Writing fw_status register failed\n");
>>>> +			return -EIO;
>>>> +		}
>>>> +
>>>> +		n_tries++;
>>>> +
>>>> +		if (n_tries <= N_WAKEUP_TRIES_SHORT_INTERVAL)
>>>> +			usleep_range(400, 700);
>>>> +		else
>>>> +			msleep(10);
>>>> +	} while (n_tries <= N_WAKEUP_TRIES_SHORT_INTERVAL + N_WAKEUP_TRIES_LONG_INTERVAL &&
>>>> +		 READ_ONCE(adapter->int_status) == 0);
>>>
>>> Can't you use read_poll_timeout() twice instead of this custom approach?
>>
>> I've tried this now, but read_poll_timeout() is not ideal for our use-case.
>> What we'd need would be read->sleep->poll->repeat instead of
>> read->poll->sleep->repeat. With read_poll_timeout() we always end up doing
>> one more (unnecessary) write.
> 
> First of all, there is a parameter to get sleep beforehand.

Sleeping beforehand will sleep before doing the first write, so that's 
just wasted time.

> Second, what is the problem with having one write more or less?
> Your current code doesn't guarantee this either. It only decreases
> probability of such scenario. Am I wrong?
> 
> 

Indeed my approach just decreases the probability and we sometimes end 
up writing twice to wakeup the card, but it would kinda bug me if we'd 
always do one write too much.

Anyway, if you still prefer the read_poll_timeout() solution I'd be 
alright with that of course.

  reply	other threads:[~2021-09-30 21:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 11:48 [PATCH v2 0/2] mwifiex: Work around firmware bugs on 88W8897 chip Jonas Dreßler
2021-09-14 11:48 ` [PATCH v2 1/2] mwifiex: Use non-posted PCI write when setting TX ring write pointer Jonas Dreßler
2021-09-22 11:17   ` Andy Shevchenko
2021-09-22 12:08     ` Jonas Dreßler
2021-09-22 13:22       ` Andy Shevchenko
2021-09-22 14:03   ` David Laight
2021-09-22 14:27     ` Pali Rohár
2021-09-22 15:54       ` David Laight
2021-09-30 14:27         ` Jonas Dreßler
2021-10-06 16:01           ` Jonas Dreßler
2021-09-14 11:48 ` [PATCH v2 2/2] mwifiex: Try waking the firmware until we get an interrupt Jonas Dreßler
2021-09-22 11:19   ` Andy Shevchenko
2021-09-30 18:04     ` Jonas Dreßler
2021-09-30 20:58       ` Andy Shevchenko
2021-09-30 21:07         ` Jonas Dreßler [this message]
2021-09-30 21:16           ` Andy Shevchenko
2021-10-03  9:18   ` Jonas Dreßler
2021-10-04 17:52     ` Brian Norris
2021-09-27 20:30 ` [PATCH v2 0/2] mwifiex: Work around firmware bugs on 88W8897 chip Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98c1b772-ae6b-e435-030e-399f613061ba@v0yd.nl \
    --to=verdre@v0yd.nl \
    --cc=amitkarwar@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=briannorris@chromium.org \
    --cc=davem@davemloft.net \
    --cc=ganapathi017@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=huxinming820@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=kitakar@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luzmaximilian@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pali@kernel.org \
    --cc=stable@vger.kernel.org \
    --subject='Re: [PATCH v2 2/2] mwifiex: Try waking the firmware until we get an interrupt' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).