LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: Tim Harvey <tharvey@gateworks.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH REPOST] TDA1997x: replace video detection routine
Date: Wed, 21 Jul 2021 12:04:26 +0200	[thread overview]
Message-ID: <99ca51b7-804e-1a53-765c-013093d38598@xs4all.nl> (raw)
In-Reply-To: <m3a6mgdrsa.fsf@t19.piap.pl>

On 21/07/2021 09:56, Krzysztof Hałasa wrote:
> Hi Hans,
> 
> Hans Verkuil <hverkuil@xs4all.nl> writes:
> 
>>> --- a/drivers/media/i2c/tda1997x.c
>>> +++ b/drivers/media/i2c/tda1997x.c
>>> @@ -1092,66 +1094,71 @@ tda1997x_detect_std(struct tda1997x_state *state,
>>>  		    struct v4l2_dv_timings *timings)
> 
> ...
> 
>>> +	if (!timings)
>>> +		return 0;
>>
>> This check isn't necessary, timings is never NULL.
> 
> Well, the tda1997x_irq_sus() does this:
> 
> 	if (debug)
> 		tda1997x_detect_std(state, NULL);

Ah, I missed that. Then you can keep that check.

Regards,

	Hans

> 
> Perhaps there is a better way, but I think I will leave it for now.
> Also there is the issue of ignoring tda1997x_detect_std() return value,
> but I can now see it's only a case in tda1997x_query_dv_timings(), easy
> to fix.
> 
> Will post an update shortly.
> 
> Thanks for your comments,
> 


  reply	other threads:[~2021-07-21 10:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19  9:30 Krzysztof Hałasa
2021-07-21  7:12 ` Hans Verkuil
2021-07-21  7:56   ` Krzysztof Hałasa
2021-07-21 10:04     ` Hans Verkuil [this message]
2021-07-22  6:27   ` Krzysztof Hałasa
2021-07-22  6:43     ` Krzysztof Hałasa
2021-07-23  8:24       ` Hans Verkuil
2021-07-23  8:49     ` Hans Verkuil
2021-07-23 11:57       ` Krzysztof Hałasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99ca51b7-804e-1a53-765c-013093d38598@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=khalasa@piap.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=tharvey@gateworks.com \
    --subject='Re: [PATCH REPOST] TDA1997x: replace video detection routine' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).