LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Martin Kepplinger <martin.kepplinger@puri.sm>
To: Pavel Machek <pavel@ucw.cz>
Cc: devicetree@vger.kernel.org, kernel@puri.sm,
	krzysztof.kozlowski@canonical.com,
	laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, mchehab@kernel.org,
	paul.kocialkowski@bootlin.com, phone-devel@vger.kernel.org,
	robh@kernel.org, sakari.ailus@iki.fi, shawnx.tu@intel.com
Subject: Re: [PATCH v8 3/4] media: i2c: add driver for the SK Hynix Hi-846 8M pixel camera
Date: Mon, 06 Sep 2021 09:49:09 +0200	[thread overview]
Message-ID: <99d6902d8e4ed68de4c011d618344485552002ea.camel@puri.sm> (raw)
In-Reply-To: <20210903161742.GD2209@bug>

Am Freitag, dem 03.09.2021 um 18:17 +0200 schrieb Pavel Machek:
> Hi!
> 
> > The SK Hynix Hi-846 is a 1/4" 8M Pixel CMOS Image Sensor. It
> > supports
> > usual features like I2C control, CSI-2 for frame data,
> > digital/analog
> > gain control or test patterns.
> > 
> > This driver supports the 640x480, 1280x720 and 1632x1224 resolution
> > modes. It supports runtime PM in order not to draw any unnecessary
> > power.
> > 
> > The part is also called YACG4D0C9SHC and a datasheet can be found
> > at
> > https://product.skhynix.com/products/cis/cis.go
> > 
> > The large sets of partly undocumented register values are for
> > example
> > found when searching for the hi846_mipi_raw_Sensor.c Android
> > driver.
> > 
> > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> 
> Reviewed-by: Pavel Machek <pavel@ucw.cz>
> 
> Some nitpicks below..
> 
> > +config VIDEO_HI846
> > +       tristate "Hynix Hi-846 sensor support"
> > +       depends on I2C && VIDEO_V4L2
> > +       select MEDIA_CONTROLLER
> > +       select VIDEO_V4L2_SUBDEV_API
> > +       select V4L2_FWNODE
> > +       help
> > +         This is a Video4Linux2 sensor driver for the Hynix
> > +         Hi-846 camera.
> > +
> > +         To compile this driver as a module, choose M here: the
> > +         module will be called hi846.
> 
> hi846.ko?

hi Pavel, thanks a lot for taking the time! the module name doesn't
include the file ending, according to all other Kconfig descriptions.

the rest looks good and I'll change it according to your review.

                           martin




  reply	other threads:[~2021-09-06  7:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 13:43 [PATCH v8 0/4] Add support for the Hynix Hi-846 camera Martin Kepplinger
2021-08-31 13:43 ` [PATCH v8 1/4] dt-bindings: vendor-prefixes: Add SK Hynix Inc Martin Kepplinger
2021-08-31 13:43 ` [PATCH v8 2/4] dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor Martin Kepplinger
2021-08-31 13:43 ` [PATCH v8 3/4] media: i2c: add driver for the SK Hynix Hi-846 8M pixel camera Martin Kepplinger
2021-09-03 16:17   ` Pavel Machek
2021-09-06  7:49     ` Martin Kepplinger [this message]
2021-09-06  7:53     ` Sakari Ailus
2021-08-31 13:43 ` [PATCH v8 4/4] Documentation: i2c-cardlist: add the Hynix hi846 sensor Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99d6902d8e4ed68de4c011d618344485552002ea.camel@puri.sm \
    --to=martin.kepplinger@puri.sm \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@puri.sm \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=pavel@ucw.cz \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@iki.fi \
    --cc=shawnx.tu@intel.com \
    --subject='Re: [PATCH v8 3/4] media: i2c: add driver for the SK Hynix Hi-846 8M pixel camera' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).