LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, kvm@vger.kernel.org
Cc: Jim Mattson <jmattson@google.com>,
	Sean Christopherson <sean.j.christopherson@intel.com>,
	Bandan Das <bsd@redhat.com>, Oliver Upton <oupton@google.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] KVM: x86: clear stale x86_emulate_ctxt->intercept value
Date: Tue, 3 Mar 2020 17:37:32 +0100	[thread overview]
Message-ID: <99fc27f9-bf89-7db1-d333-1433ebfa4e89@redhat.com> (raw)
In-Reply-To: <87zhcxe6qe.fsf@vitty.brq.redhat.com>

On 03/03/20 17:35, Vitaly Kuznetsov wrote:
>>
>> "f3 a5" is a "rep movsw" instruction, which should not be intercepted
>> at all.  Commit c44b4c6ab80e ("KVM: emulate: clean up initializations in
>> init_decode_cache") reduced the number of fields cleared by
>> init_decode_cache() claiming that they are being cleared elsewhere,
>> 'intercept', however, is left uncleared if the instruction does not have
>> any of the "slow path" flags (NotImpl, Stack, Op3264, Sse, Mmx, CheckPerm,
>> NearBranch, No16 and of course Intercept itself).
> Much better, thanks) Please let me know if you want me to resubmit.

No need, thanks.

Paolo


  reply	other threads:[~2020-03-03 16:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03 14:33 [PATCH 0/2] KVM: x86: avoid using " Vitaly Kuznetsov
2020-03-03 14:33 ` [PATCH 1/2] KVM: x86: clear " Vitaly Kuznetsov
2020-03-03 15:42   ` Sean Christopherson
2020-03-03 16:21   ` Paolo Bonzini
2020-03-03 16:35     ` Vitaly Kuznetsov
2020-03-03 16:37       ` Paolo Bonzini [this message]
2020-03-03 14:33 ` [PATCH 2/2] KVM: x86: remove stale comment from struct x86_emulate_ctxt Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99fc27f9-bf89-7db1-d333-1433ebfa4e89@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=bsd@redhat.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oupton@google.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=vkuznets@redhat.com \
    --subject='Re: [PATCH 1/2] KVM: x86: clear stale x86_emulate_ctxt->intercept value' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).