LKML Archive on
help / color / mirror / Atom feed
From: Paolo Bonzini <>
To: Vitaly Kuznetsov <>,
Cc: Jim Mattson <>,
	Sean Christopherson <>,
	Bandan Das <>, Oliver Upton <>,
Subject: Re: [PATCH 1/2] KVM: x86: clear stale x86_emulate_ctxt->intercept value
Date: Tue, 3 Mar 2020 17:37:32 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 03/03/20 17:35, Vitaly Kuznetsov wrote:
>> "f3 a5" is a "rep movsw" instruction, which should not be intercepted
>> at all.  Commit c44b4c6ab80e ("KVM: emulate: clean up initializations in
>> init_decode_cache") reduced the number of fields cleared by
>> init_decode_cache() claiming that they are being cleared elsewhere,
>> 'intercept', however, is left uncleared if the instruction does not have
>> any of the "slow path" flags (NotImpl, Stack, Op3264, Sse, Mmx, CheckPerm,
>> NearBranch, No16 and of course Intercept itself).
> Much better, thanks) Please let me know if you want me to resubmit.

No need, thanks.


  reply	other threads:[~2020-03-03 16:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03 14:33 [PATCH 0/2] KVM: x86: avoid using " Vitaly Kuznetsov
2020-03-03 14:33 ` [PATCH 1/2] KVM: x86: clear " Vitaly Kuznetsov
2020-03-03 15:42   ` Sean Christopherson
2020-03-03 16:21   ` Paolo Bonzini
2020-03-03 16:35     ` Vitaly Kuznetsov
2020-03-03 16:37       ` Paolo Bonzini [this message]
2020-03-03 14:33 ` [PATCH 2/2] KVM: x86: remove stale comment from struct x86_emulate_ctxt Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 1/2] KVM: x86: clear stale x86_emulate_ctxt->intercept value' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).