LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] arm64: dts: fsl: imx8mq: enable the svns power key
@ 2019-05-28 12:44 Angus Ainslie (Purism)
  2019-05-28 12:51 ` Lucas Stach
  0 siblings, 1 reply; 3+ messages in thread
From: Angus Ainslie (Purism) @ 2019-05-28 12:44 UTC (permalink / raw)
  To: angus.ainslie
  Cc: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Lucas Stach, Abel Vesa, Andrey Smirnov, Angus Ainslie (Purism),
	Carlo Caione, Guido Günther, devicetree, linux-arm-kernel,
	linux-kernel

Add the snvs power key.

Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 45d10d8efd14..5f93fd9662ae 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -8,6 +8,7 @@
 #include <dt-bindings/power/imx8mq-power.h>
 #include <dt-bindings/reset/imx8mq-reset.h>
 #include <dt-bindings/gpio/gpio.h>
+#include "dt-bindings/input/input.h"
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/thermal/thermal.h>
 #include "imx8mq-pinfunc.h"
@@ -463,6 +464,14 @@
 					interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
 						<GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
 				};
+
+				snvs_pwrkey: snvs-powerkey {
+					compatible = "fsl,sec-v4.0-pwrkey";
+					regmap = <&snvs>;
+					interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
+					linux,keycode = <KEY_POWER>;
+					wakeup-source;
+				};
 			};
 
 			clk: clock-controller@30380000 {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: fsl: imx8mq: enable the svns power key
  2019-05-28 12:44 [PATCH] arm64: dts: fsl: imx8mq: enable the svns power key Angus Ainslie (Purism)
@ 2019-05-28 12:51 ` Lucas Stach
  2019-05-28 13:00   ` Angus Ainslie
  0 siblings, 1 reply; 3+ messages in thread
From: Lucas Stach @ 2019-05-28 12:51 UTC (permalink / raw)
  To: Angus Ainslie (Purism), angus.ainslie
  Cc: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Abel Vesa, Andrey Smirnov, Carlo Caione, Guido Günther,
	devicetree, linux-arm-kernel, linux-kernel

Hi Angus,

Am Dienstag, den 28.05.2019, 05:44 -0700 schrieb Angus Ainslie (Purism):
> Add the snvs power key.
> 
> > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 45d10d8efd14..5f93fd9662ae 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -8,6 +8,7 @@
>  #include <dt-bindings/power/imx8mq-power.h>
>  #include <dt-bindings/reset/imx8mq-reset.h>
>  #include <dt-bindings/gpio/gpio.h>
> +#include "dt-bindings/input/input.h"
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/thermal/thermal.h>
>  #include "imx8mq-pinfunc.h"
> @@ -463,6 +464,14 @@
> >  					interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
> >  						<GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
> >  				};
> +
> > +				snvs_pwrkey: snvs-powerkey {
> > +					compatible = "fsl,sec-v4.0-pwrkey";
> > +					regmap = <&snvs>;
> > +					interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> > +					linux,keycode = <KEY_POWER>;
> +					wakeup-source;

Not all i.MX8MQ systems will have this functionality wired up at the
board level, so this node needs to be disabled by default. The existing
 i.MX6 and i.MX7 DTs seem to get this wrong.

Regards,
Lucas

> +				};
> >  			};
>  
> > >  			clk: clock-controller@30380000 {

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: fsl: imx8mq: enable the svns power key
  2019-05-28 12:51 ` Lucas Stach
@ 2019-05-28 13:00   ` Angus Ainslie
  0 siblings, 0 replies; 3+ messages in thread
From: Angus Ainslie @ 2019-05-28 13:00 UTC (permalink / raw)
  To: Lucas Stach
  Cc: angus.ainslie, Rob Herring, Mark Rutland, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Abel Vesa, Andrey Smirnov, Carlo Caione,
	Guido Günther, devicetree, linux-arm-kernel, linux-kernel

Hi Lucas,

On 2019-05-28 05:51, Lucas Stach wrote:
> Hi Angus,
> 
> Am Dienstag, den 28.05.2019, 05:44 -0700 schrieb Angus Ainslie 
> (Purism):
>> Add the snvs power key.
>> 
>> > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
>> ---
>>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi 
>> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> index 45d10d8efd14..5f93fd9662ae 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> @@ -8,6 +8,7 @@
>>  #include <dt-bindings/power/imx8mq-power.h>
>>  #include <dt-bindings/reset/imx8mq-reset.h>
>>  #include <dt-bindings/gpio/gpio.h>
>> +#include "dt-bindings/input/input.h"
>>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>>  #include <dt-bindings/thermal/thermal.h>
>>  #include "imx8mq-pinfunc.h"
>> @@ -463,6 +464,14 @@
>> >  					interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
>> >  						<GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
>> >  				};
>> +
>> > +				snvs_pwrkey: snvs-powerkey {
>> > +					compatible = "fsl,sec-v4.0-pwrkey";
>> > +					regmap = <&snvs>;
>> > +					interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
>> > +					linux,keycode = <KEY_POWER>;
>> +					wakeup-source;
> 
> Not all i.MX8MQ systems will have this functionality wired up at the
> board level, so this node needs to be disabled by default. The existing
>  i.MX6 and i.MX7 DTs seem to get this wrong.
> 

Ok I'll fix that for the next rev.

Thanks
Angus

> Regards,
> Lucas
> 
>> +				};
>> >  			};
>>  
>> > >  			clk: clock-controller@30380000 {


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-28 13:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-28 12:44 [PATCH] arm64: dts: fsl: imx8mq: enable the svns power key Angus Ainslie (Purism)
2019-05-28 12:51 ` Lucas Stach
2019-05-28 13:00   ` Angus Ainslie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).