Re: [patch 1/3, resend] scripts: replace gawk, head, bc with shell, update

["Jesper Juhl" <jesper.juhl@gmail.com>]

On 06/02/07, Oleg Verych <olecom@flower.upol.cz> wrote:
> scripts: replace gawk, head, bc with shell, update
>
>   Replacing overhead of using some (external) programs
>   instead of good old `sh'.
>
> Cc: Roman Zippel <zippel@linux-m68k.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: William Stearns <wstearns@pobox.com>
> Cc: Martin Schlemmer <azarah@nosferatu.za.org>
> Signed-off-by: Oleg Verych <olecom@flower.upol.cz>
> ---
>
>  Whitespace cleanup included.
>
>  scripts/gen_initramfs_list.sh | 43 +++++++++++++++++++++---------------------
>  scripts/makelst               | 34 ++++++++++++++++-----------------
>  2 files changed, 39 insertions(+), 38 deletions(-)
>
> Index: linux-2.6.20/scripts/makelst
> ===================================================================
> --- linux-2.6.20.orig/scripts/makelst   2007-02-06 02:12:38.811908000 +0100
> +++ linux-2.6.20/scripts/makelst        2007-02-06 02:12:43.688212750 +0100
> @@ -1,31 +1,31 @@
> -#!/bin/bash
> +#!/bin/sh

I don't like this change much.  We don't know what shell /bin/sh is on
a random users system - much better to be explicit and make sure we
use/require bash.
I expect this change to cause pain for users who have zsh, csh, ksh,
ash or some other shell as /bin/sh but also have /bin/bash available.
Previously things would just work, but now it will possibly break due
to using a different shell.

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html