From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1161045AbXBGI6P@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161045AbXBGI6P (ORCPT <rfc822;w@1wt.eu>);
	Wed, 7 Feb 2007 03:58:15 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161046AbXBGI6P
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 7 Feb 2007 03:58:15 -0500
Received: from wr-out-0506.google.com ([64.233.184.235]:34276 "EHLO
	wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1161045AbXBGI6N (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 7 Feb 2007 03:58:13 -0500
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=aRx+eYLZSkYn3YYOwtn2aPi8PIyuH2G5PMo+947IRZHjW6Gb0Mc0UrqCL2imvJdSk1sKiNxO5TIn7Ges2LI9Yfx14Tnl+dXiw0aWmBSvsajT3GUKrKy8LM3cZ3e9INyibWa0lrJwfFnwlig2+ahrxuvYKWAzXSc9H1Hi2XxAGCI=
Message-ID: <9a8748490702070058rab5a9d6vd57cf49b722e4850@mail.gmail.com>
Date: Wed, 7 Feb 2007 09:58:12 +0100
From: "Jesper Juhl" <jesper.juhl@gmail.com>
To: "Oleg Verych" <olecom@flower.upol.cz>
Subject: Re: [patch 1/3, resend] scripts: replace gawk, head, bc with shell, update
Cc: LKML <linux-kernel@vger.kernel.org>,
       "Andrew Morton" <akpm@linux-foundation.org>,
       "Linus Torvalds" <torvalds@linux-foundation.org>,
       "Roman Zippel" <zippel@linux-m68k.org>,
       "Sam Ravnborg" <sam@ravnborg.org>,
       "William Stearns" <wstearns@pobox.com>,
       "Martin Schlemmer" <azarah@nosferatu.za.org>
In-Reply-To: <20070206012207.805083000@flower.upol.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20070206011819.160359000@flower.upol.cz>
	 <20070206012207.805083000@flower.upol.cz>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/02/07, Oleg Verych <olecom@flower.upol.cz> wrote:
> scripts: replace gawk, head, bc with shell, update
>
>   Replacing overhead of using some (external) programs
>   instead of good old `sh'.
>
> Cc: Roman Zippel <zippel@linux-m68k.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: William Stearns <wstearns@pobox.com>
> Cc: Martin Schlemmer <azarah@nosferatu.za.org>
> Signed-off-by: Oleg Verych <olecom@flower.upol.cz>
> ---
>
>  Whitespace cleanup included.
>
>  scripts/gen_initramfs_list.sh | 43 +++++++++++++++++++++---------------------
>  scripts/makelst               | 34 ++++++++++++++++-----------------
>  2 files changed, 39 insertions(+), 38 deletions(-)
>
> Index: linux-2.6.20/scripts/makelst
> ===================================================================
> --- linux-2.6.20.orig/scripts/makelst   2007-02-06 02:12:38.811908000 +0100
> +++ linux-2.6.20/scripts/makelst        2007-02-06 02:12:43.688212750 +0100
> @@ -1,31 +1,31 @@
> -#!/bin/bash
> +#!/bin/sh

I don't like this change much.  We don't know what shell /bin/sh is on
a random users system - much better to be explicit and make sure we
use/require bash.
I expect this change to cause pain for users who have zsh, csh, ksh,
ash or some other shell as /bin/sh but also have /bin/bash available.
Previously things would just work, but now it will possibly break due
to using a different shell.

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html