LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Yang Yingliang <yangyingliang@huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
	<prabhakar.mahadev-lad.rj@bp.renesas.com>, <jic23@kernel.org>
Subject: Re: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume()
Date: Fri, 20 Aug 2021 09:52:33 +0800	[thread overview]
Message-ID: <9b848f1c-9acd-243e-2c5b-d489d2427464@huawei.com> (raw)
In-Reply-To: <CAHp75Vd22aP098s9iXCGmBG505dW1vmZgvy3h9NoNA=J-eQ-CQ@mail.gmail.com>

Hi,

On 2021/8/20 1:20, Andy Shevchenko wrote:
> On Thu, Aug 19, 2021 at 4:19 PM Yang Yingliang <yangyingliang@huawei.com> wrote:
>> Add clk_disable_unprepare() on error path in rzg2l_adc_pm_runtime_resume().
> ...
>
>>          ret = clk_prepare_enable(adc->adclk);
>> -       if (ret)
>> +       if (ret) {
>> +               clk_disable_unprepare(adc->pclk);
>>                  return ret;
>> +       }
> Huh?!
The pclk need be disabled, when enable adclk failed.
       ^                                                         ^^
>

  reply	other threads:[~2021-08-20  1:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19 13:24 Yang Yingliang
2021-08-19 17:20 ` Andy Shevchenko
2021-08-20  1:52   ` Yang Yingliang [this message]
2021-08-20  9:17     ` Andy Shevchenko
2021-08-30 10:58       ` Jonathan Cameron
2021-08-20  6:46   ` Sa, Nuno
2021-08-20 14:04 ` Prabhakar Mahadev Lad
2021-08-30 11:00   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b848f1c-9acd-243e-2c5b-d489d2427464@huawei.com \
    --to=yangyingliang@huawei.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --subject='Re: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).