LKML Archive on
help / color / mirror / Atom feed
From: Sylwester Nawrocki <>
To: Krzysztof Kozlowski <>
Cc: Sangbeom Kim <>,
	Liam Girdwood <>,
	Mark Brown <>, Rob Herring <>,
	Mark Rutland <>,,,
Subject: Re: [PATCH v2] ASoC: samsung: Mark unused Odroid compatibles as deprecated
Date: Mon, 19 Mar 2018 11:29:22 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 03/18/2018 04:35 PM, Krzysztof Kozlowski wrote:
> Compatible for XU4 audio is not being used.  Instead the board uses the
> same compatible as XU3.  The devices are now just compatible so they
> should use the same value.  Mark "hardkernel,odroid-xu4-audio" as being
> deprecated so in this future could be removed to limit useless
> properties.

It doesn't feel right to obsolete the "hardkernel,odroid-xu4-audio"
compatible, there is significant difference between XU3 and XU4 - there
is no audio CODEC on XU4, this board only supports audio over HDMI interface.
XU4 could be compatible with XU3, but not the other way around.
It just happens we have other DT properties that help to handle such HW 
design difference.

Moreover, only XU4 is still in production and should be in few more years [1], 
others are obsoleted now.

So I think we should keep at least these 2 compatible strings:

- "hardkernel,odroid-xu3-audio" - for boards with audio CODEC,
- "hardkernel,odroid-xu4-audio" - for boards without audio CODEC, 
   supporting only HDMI interface.



  parent reply	other threads:[~2018-03-19 10:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2018-03-18 15:35 ` Krzysztof Kozlowski
2018-03-19  1:03   ` Applied "ASoC: samsung: Mark unused Odroid compatibles as deprecated" to the asoc tree Mark Brown
     [not found]   ` <>
2018-03-19 10:29     ` Sylwester Nawrocki [this message]
2018-03-19 10:56       ` [PATCH v2] ASoC: samsung: Mark unused Odroid compatibles as deprecated Krzysztof Kozlowski
2018-03-19 15:14         ` Sylwester Nawrocki
2018-03-20  7:11           ` Krzysztof Kozlowski
2018-03-20 18:08             ` Sylwester Nawrocki
2018-03-19 15:16   ` Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] ASoC: samsung: Mark unused Odroid compatibles as deprecated' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).