LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@micronovasrl.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	"open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
	<linux-rtc@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] rtc: ds1307: add offset sysfs for mt41txx chips.
Date: Wed, 18 Jul 2018 10:45:25 +0200	[thread overview]
Message-ID: <9bc8a049-8f43-b9b1-8926-5521ff26077a@micronovasrl.com> (raw)
In-Reply-To: <20180718084118.79540-2-giulio.benetti@micronovasrl.com>

Hi,

please discard this patchset as I didn't add v7 to series.
Sorry.

Giulio

Il 18/07/2018 10:41, Giulio Benetti ha scritto:
> m41txx chips can hold a calibration value to get correct clock bias.
> 
> Add offset handling (ranging between -63ppm and 126ppm) via sysfs.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>   drivers/rtc/rtc-ds1307.c | 77 ++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 77 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
> index 0162a600ff1b..b2ef9defc349 100644
> --- a/drivers/rtc/rtc-ds1307.c
> +++ b/drivers/rtc/rtc-ds1307.c
> @@ -114,6 +114,20 @@ enum ds_type {
>   #	define RX8025_BIT_VDET		0x40
>   #	define RX8025_BIT_XST		0x20
>   
> +#define M41TXX_REG_CONTROL	0x07
> +#	define M41TXX_BIT_OUT		0x80
> +#	define M41TXX_BIT_FT		0x40
> +#	define M41TXX_BIT_CALIB_SIGN	0x20
> +#	define M41TXX_M_CALIBRATION	0x1f
> +
> +/* negative offset step is -2.034ppm */
> +#define M41TXX_NEG_OFFSET_STEP_PPB	2034
> +/* positive offset step is +4.068ppm */
> +#define M41TXX_POS_OFFSET_STEP_PPB	4068
> +/* Min and max values supported with 'offset' interface by M41TXX */
> +#define M41TXX_MIN_OFFSET	((-31) * M41TXX_NEG_OFFSET_STEP_PPB)
> +#define M41TXX_MAX_OFFSET	((31) * M41TXX_POS_OFFSET_STEP_PPB)
> +
>   struct ds1307 {
>   	enum ds_type		type;
>   	unsigned long		flags;
> @@ -146,6 +160,9 @@ struct chip_desc {
>   
>   static int ds1307_get_time(struct device *dev, struct rtc_time *t);
>   static int ds1307_set_time(struct device *dev, struct rtc_time *t);
> +static int ds1337_read_alarm(struct device *dev, struct rtc_wkalrm *t);
> +static int ds1337_set_alarm(struct device *dev, struct rtc_wkalrm *t);
> +static int ds1307_alarm_irq_enable(struct device *dev, unsigned int enabled);
>   static u8 do_trickle_setup_ds1339(struct ds1307 *, u32 ohms, bool diode);
>   static irqreturn_t rx8130_irq(int irq, void *dev_id);
>   static int rx8130_read_alarm(struct device *dev, struct rtc_wkalrm *t);
> @@ -155,6 +172,8 @@ static irqreturn_t mcp794xx_irq(int irq, void *dev_id);
>   static int mcp794xx_read_alarm(struct device *dev, struct rtc_wkalrm *t);
>   static int mcp794xx_set_alarm(struct device *dev, struct rtc_wkalrm *t);
>   static int mcp794xx_alarm_irq_enable(struct device *dev, unsigned int enabled);
> +static int m41txx_rtc_read_offset(struct device *dev, long *offset);
> +static int m41txx_rtc_set_offset(struct device *dev, long offset);
>   
>   static const struct rtc_class_ops rx8130_rtc_ops = {
>   	.read_time      = ds1307_get_time,
> @@ -172,6 +191,16 @@ static const struct rtc_class_ops mcp794xx_rtc_ops = {
>   	.alarm_irq_enable = mcp794xx_alarm_irq_enable,
>   };
>   
> +static const struct rtc_class_ops m41txx_rtc_ops = {
> +	.read_time      = ds1307_get_time,
> +	.set_time       = ds1307_set_time,
> +	.read_alarm	= ds1337_read_alarm,
> +	.set_alarm	= ds1337_set_alarm,
> +	.alarm_irq_enable = ds1307_alarm_irq_enable,
> +	.read_offset	= m41txx_rtc_read_offset,
> +	.set_offset	= m41txx_rtc_set_offset,
> +};
> +
>   static const struct chip_desc chips[last_ds_type] = {
>   	[ds_1307] = {
>   		.nvram_offset	= 8,
> @@ -228,10 +257,17 @@ static const struct chip_desc chips[last_ds_type] = {
>   		.irq_handler = rx8130_irq,
>   		.rtc_ops = &rx8130_rtc_ops,
>   	},
> +	[m41t0] = {
> +		.rtc_ops	= &m41txx_rtc_ops,
> +	},
> +	[m41t00] = {
> +		.rtc_ops	= &m41txx_rtc_ops,
> +	},
>   	[m41t11] = {
>   		/* this is battery backed SRAM */
>   		.nvram_offset	= 8,
>   		.nvram_size	= 56,
> +		.rtc_ops	= &m41txx_rtc_ops,
>   	},
>   	[mcp794xx] = {
>   		.alarm		= 1,
> @@ -973,6 +1009,47 @@ static int mcp794xx_alarm_irq_enable(struct device *dev, unsigned int enabled)
>   				  enabled ? MCP794XX_BIT_ALM0_EN : 0);
>   }
>   
> +static int m41txx_rtc_read_offset(struct device *dev, long *offset)
> +{
> +	struct ds1307 *ds1307 = dev_get_drvdata(dev);
> +	unsigned int ctrl_reg;
> +	u8 val;
> +
> +	regmap_read(ds1307->regmap, M41TXX_REG_CONTROL, &ctrl_reg);
> +
> +	val = ctrl_reg & M41TXX_M_CALIBRATION;
> +
> +	/* check if positive */
> +	if (ctrl_reg & M41TXX_BIT_CALIB_SIGN)
> +		*offset = (val * M41TXX_POS_OFFSET_STEP_PPB);
> +	else
> +		*offset = -(val * M41TXX_NEG_OFFSET_STEP_PPB);
> +
> +	return 0;
> +}
> +
> +static int m41txx_rtc_set_offset(struct device *dev, long offset)
> +{
> +	struct ds1307 *ds1307 = dev_get_drvdata(dev);
> +	unsigned int ctrl_reg;
> +
> +	if ((offset < M41TXX_MIN_OFFSET) || (offset > M41TXX_MAX_OFFSET))
> +		return -ERANGE;
> +
> +	if (offset >= 0) {
> +		ctrl_reg = DIV_ROUND_CLOSEST(offset,
> +					     M41TXX_POS_OFFSET_STEP_PPB);
> +		ctrl_reg |= M41TXX_BIT_CALIB_SIGN;
> +	} else {
> +		ctrl_reg = DIV_ROUND_CLOSEST(abs(offset),
> +					     M41TXX_NEG_OFFSET_STEP_PPB);
> +	}
> +
> +	return regmap_update_bits(ds1307->regmap, M41TXX_REG_CONTROL,
> +				  M41TXX_M_CALIBRATION | M41TXX_BIT_CALIB_SIGN,
> +				  ctrl_reg);
> +}
> +
>   /*----------------------------------------------------------------------*/
>   
>   static int ds1307_nvram_read(void *priv, unsigned int offset, void *val,
> 

  reply	other threads:[~2018-07-18  8:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 21:08 [PATCH v6 1/4] rtc: ds1307: fix data pointer to m41t0 Giulio Benetti
2018-05-16 21:08 ` [PATCH v6 2/4] rtc: ds1307: support m41t11 variant Giulio Benetti
2018-05-18 16:35   ` Rob Herring
2018-07-16 21:37   ` Alexandre Belloni
2018-05-16 21:08 ` [PATCH v6 3/4] rtc: ds1307: add offset sysfs for mt41txx chips Giulio Benetti
2018-07-16 21:33   ` Alexandre Belloni
2018-07-18  8:41     ` [PATCH 2/4] rtc: ds1307: support m41t11 variant Giulio Benetti
2018-07-18  8:41       ` [PATCH 3/4] rtc: ds1307: add offset sysfs for mt41txx chips Giulio Benetti
2018-07-18  8:45         ` Giulio Benetti [this message]
2018-07-18  8:41       ` [PATCH 4/4] rtc: ds1307: add frequency_test_enable sysfs attribute to check tick on m41txx Giulio Benetti
2018-07-18  8:41       ` [PATCH 1/4] rtc: ds1307: fix data pointer to m41t0 Giulio Benetti
2018-05-16 21:08 ` [PATCH v6 4/4] rtc: ds1307: add frequency_test_enable sysfs attribute to check tick on m41txx Giulio Benetti
2018-07-16 21:36 ` [PATCH v6 1/4] rtc: ds1307: fix data pointer to m41t0 Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bc8a049-8f43-b9b1-8926-5521ff26077a@micronovasrl.com \
    --to=giulio.benetti@micronovasrl.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --subject='Re: [PATCH 3/4] rtc: ds1307: add offset sysfs for mt41txx chips.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).