LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: sniper <s3c24xx@gmail.com>
To: mingo@redhat.com, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] LOCKDEP: minor fix for debug_show_all_locks()
Date: Tue, 28 Oct 2008 04:03:52 +0800	[thread overview]
Message-ID: <9bd6b5360810271303teb198dejde3116f69cfffd46@mail.gmail.com> (raw)

When we failed to get tasklist_lock eventually (count equals 0),
we should only print " ignoring it.\n", and not print
" locked it.\n" needlessly.

Signed-off-by: Qinghuang Feng <qhfeng.kernel@gmail.com>
---
diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index dbda475..12bf812 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -3417,10 +3417,12 @@ retry:
 		}
 		printk(" ignoring it.\n");
 		unlock = 0;
+		goto print_locks;
 	}
 	if (count != 10)
 		printk(" locked it.\n");

+print_locks:
 	do_each_thread(g, p) {
 		/*
 		 * It's not reliable to print a task's held locks

             reply	other threads:[~2008-10-27 20:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-27 20:03 sniper [this message]
2008-10-28  8:29 ` Ingo Molnar
2008-10-28  9:24   ` qinghuang feng
2008-10-28  9:31     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bd6b5360810271303teb198dejde3116f69cfffd46@mail.gmail.com \
    --to=s3c24xx@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --subject='Re: [PATCH] LOCKDEP: minor fix for debug_show_all_locks()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).