LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Jean-Marc Valin <jmvalin@mozilla.com>,
	airlied@linux.ie, alexander.deucher@amd.com,
	christian.koenig@amd.com, Felix.Kuehling@amd.com,
	labbott@redhat.com, akpm@linux-foundation.org,
	michel.daenzer@amd.com, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: AMD graphics performance regression in 4.15 and later
Date: Fri, 6 Apr 2018 10:03:41 +0200	[thread overview]
Message-ID: <9ca940f1-7f21-c420-de45-13d72e783ab6@amd.com> (raw)
In-Reply-To: <c743b220-0395-eef3-4405-a21cdbe8eee1@mozilla.com>

Hi Jean,

yeah, that is a known problem. Using huge pages improves the performance 
because of better TLB usage, but for the cost of higher allocation overhead.

What we found is that firefox is doing something rather strange by 
allocating large textures and then just trowing them away again immediately.

We mitigated the problem by avoiding the slow coherent DMA code path on 
almost all platforms on newer kernels, but essentially somebody needs to 
figure out why firefox and/or the user space stack is doing this 
constant allocation/freeing of memory.

There is also a bug tracker on bugs.kernel.org about this, but I can't 
find it any more of hand.

Regards,
Christian.

Am 06.04.2018 um 02:30 schrieb Jean-Marc Valin:
> Hi,
>
> I noticed a serious graphics performance regression between 4.14 and
> 4.15. It is most noticeable with Firefox (tried FF57 through FF60) and
> causes scrolling to be really choppy/sluggish. I've confirmed that the
> problem is also there on 4.16, while 4.13 works fine.
>
> After a bisection, I've narrowed the regression down to this commit:
>
> commit 648bc3574716400acc06f99915815f80d9563783
> Author: Christian König <christian.koenig@amd.com>
> Date:   Thu Jul 6 09:59:43 2017 +0200
>
>      drm/ttm: add transparent huge page support for DMA allocations v2
>
>
> Some details about my system:
> Distro: Fedora 27 (up-to-date)
> Video: MSI Radeon RX 560 AERO
> CPU: Dual-socket Xeon E5-2640 v4 (20 cores total)
> RAM: 128 GB ECC
>
>
> As a comparison, when running Firefox with 4.15 on a Lenovo W540 laptop
> (with Intel graphics only) the responsiveness is much better then what
> I'm getting on the Xeon machine above with the Radeon card, so this
> really seems to be an AMD-only issue.
>
> Any way to fix the issue?
>
> Thanks,
>
> 	Jean-Marc
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-04-06  8:04 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06  0:30 AMD graphics performance regression in 4.15 and later Jean-Marc Valin
2018-04-06  8:03 ` Christian König [this message]
2018-04-06  8:10   ` Christian König
2018-04-06 15:30   ` Jean-Marc Valin
2018-04-09 11:48     ` Christian König
2018-04-06 16:42       ` Jean-Marc Valin
2018-04-06 17:20         ` Christian König
2018-04-06 22:00           ` Jean-Marc Valin
2018-04-09  9:42             ` Christian König
2018-04-09 15:17               ` Jean-Marc Valin
2018-04-10  6:48                 ` Christian König
2018-04-11  4:00               ` Gabriel C
2018-04-11  5:02                 ` Gabriel C
2018-06-06 11:28                   ` Gabriel C
2018-06-06 11:33                     ` Christian König
2018-06-06 12:08                       ` Gabriel C
2018-06-06 12:19                         ` Christian König
2018-04-11  9:37                 ` Christian König
2018-04-11 14:26                   ` Gabriel C
2018-04-11 17:21                     ` Gabriel C
2018-04-11 18:35                   ` Jean-Marc Valin
2018-04-11 22:20                     ` Gabriel C
2018-04-12  1:47                       ` Gabriel C
2018-04-20 14:47                   ` Michel Dänzer
2018-04-20 19:40                     ` Felix Kuehling
2018-04-23 10:23                       ` Michel Dänzer
2018-07-13  2:23       ` Jean-Marc Valin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ca940f1-7f21-c420-de45-13d72e783ab6@amd.com \
    --to=christian.koenig@amd.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.deucher@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jmvalin@mozilla.com \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michel.daenzer@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).