LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] usb: phy: tegra: Include proper GPIO consumer header to fix compile testing
@ 2020-03-03 11:29 Krzysztof Kozlowski
  2020-03-03 15:10 ` Dmitry Osipenko
  0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-03-03 11:29 UTC (permalink / raw)
  To: Felipe Balbi, Greg Kroah-Hartman, Thierry Reding,
	Jonathan Hunter, linux-usb, linux-tegra, linux-kernel
  Cc: Krzysztof Kozlowski

The driver uses only GPIO Descriptor Consumer Interface so include
proper header.  This fixes compile test failures (e.g. on i386):

    drivers/usb/phy/phy-tegra-usb.c: In function ‘ulpi_phy_power_on’:
    drivers/usb/phy/phy-tegra-usb.c:695:2: error:
        implicit declaration of function ‘gpiod_set_value_cansleep’ [-Werror=implicit-function-declaration]
    drivers/usb/phy/phy-tegra-usb.c: In function ‘tegra_usb_phy_probe’:
    drivers/usb/phy/phy-tegra-usb.c:1167:11: error:
        implicit declaration of function ‘devm_gpiod_get_from_of_node’ [-Werror=implicit-function-declaration]

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/usb/phy/phy-tegra-usb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
index 6153cc35aba0..cffe2aced488 100644
--- a/drivers/usb/phy/phy-tegra-usb.c
+++ b/drivers/usb/phy/phy-tegra-usb.c
@@ -12,12 +12,11 @@
 #include <linux/delay.h>
 #include <linux/err.h>
 #include <linux/export.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
 #include <linux/iopoll.h>
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_device.h>
-#include <linux/of_gpio.h>
 #include <linux/platform_device.h>
 #include <linux/resource.h>
 #include <linux/slab.h>
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: [PATCH] usb: phy: tegra: Include proper GPIO consumer header to fix compile testing
  2020-03-03 11:29 [PATCH] usb: phy: tegra: Include proper GPIO consumer header to fix compile testing Krzysztof Kozlowski
@ 2020-03-03 15:10 ` Dmitry Osipenko
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Osipenko @ 2020-03-03 15:10 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Felipe Balbi, Greg Kroah-Hartman,
	Thierry Reding, Jonathan Hunter, linux-usb, linux-tegra,
	linux-kernel

03.03.2020 14:29, Krzysztof Kozlowski пишет:
> The driver uses only GPIO Descriptor Consumer Interface so include
> proper header.  This fixes compile test failures (e.g. on i386):
> 
>     drivers/usb/phy/phy-tegra-usb.c: In function ‘ulpi_phy_power_on’:
>     drivers/usb/phy/phy-tegra-usb.c:695:2: error:
>         implicit declaration of function ‘gpiod_set_value_cansleep’ [-Werror=implicit-function-declaration]
>     drivers/usb/phy/phy-tegra-usb.c: In function ‘tegra_usb_phy_probe’:
>     drivers/usb/phy/phy-tegra-usb.c:1167:11: error:
>         implicit declaration of function ‘devm_gpiod_get_from_of_node’ [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/usb/phy/phy-tegra-usb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
> index 6153cc35aba0..cffe2aced488 100644
> --- a/drivers/usb/phy/phy-tegra-usb.c
> +++ b/drivers/usb/phy/phy-tegra-usb.c
> @@ -12,12 +12,11 @@
>  #include <linux/delay.h>
>  #include <linux/err.h>
>  #include <linux/export.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/iopoll.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
>  #include <linux/of_device.h>
> -#include <linux/of_gpio.h>
>  #include <linux/platform_device.h>
>  #include <linux/resource.h>
>  #include <linux/slab.h>
> 

Thanks,

Reviewed-by: Dmitry Osipenko <digetx@gmail.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-03 15:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-03 11:29 [PATCH] usb: phy: tegra: Include proper GPIO consumer header to fix compile testing Krzysztof Kozlowski
2020-03-03 15:10 ` Dmitry Osipenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).