LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Johannes Thumshirn <morbidrsa@gmail.com>,
	linux-watchdog@vger.kernel.org
Subject: Re: linux-next: Tree for Aug 3 (watchdog/menz69_wdt.c)
Date: Fri, 3 Aug 2018 08:39:48 -0700	[thread overview]
Message-ID: <9d17144d-6f19-781f-8abc-1ee1c6f840bd@infradead.org> (raw)
In-Reply-To: <20180803192942.6975df0c@canb.auug.org.au>

On 08/03/2018 02:29 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20180802:
> 

Hi,

On i386 randconfig with COMPILE_TEST=y and MCB not enabled, I see:

drivers/watchdog/menz69_wdt.o: In function `men_z069_remove':
menz69_wdt.c:(.text+0xa6): undefined reference to `mcb_release_mem'
drivers/watchdog/menz69_wdt.o: In function `men_z069_probe':
menz69_wdt.c:(.text+0xdb): undefined reference to `mcb_request_mem'
menz69_wdt.c:(.text+0x14a): undefined reference to `mcb_release_mem'
drivers/watchdog/menz69_wdt.o: In function `men_z069_driver_init':
menz69_wdt.c:(.init.text+0x15): undefined reference to `__mcb_register_driver'
drivers/watchdog/menz69_wdt.o: In function `men_z069_driver_exit':
menz69_wdt.c:(.exit.text+0x9): undefined reference to `mcb_unregister_driver'


The Kconfig for MENZ069_WATCHDOG says:
config MENZ069_WATCHDOG
	tristate "MEN 16Z069 Watchdog"
	depends on MCB || COMPILE_TEST
	select WATCHDOG_CORE

Looks to me like the driver really depends on MCB, unless someone wants
to add stubs in <linux/mcb.h>.

-- 
~Randy

  reply	other threads:[~2018-08-03 15:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03  9:29 linux-next: Tree for Aug 3 Stephen Rothwell
2018-08-03 15:39 ` Randy Dunlap [this message]
2018-08-03 16:40   ` linux-next: Tree for Aug 3 (watchdog/menz69_wdt.c) Johannes Thumshirn
2018-08-06 15:14     ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d17144d-6f19-781f-8abc-1ee1c6f840bd@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=morbidrsa@gmail.com \
    --cc=sfr@canb.auug.org.au \
    --subject='Re: linux-next: Tree for Aug 3 (watchdog/menz69_wdt.c)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).