LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Banajit Goswami <bgoswami@codeaurora.org>,
andy.gross@linaro.org, broonie@kernel.org,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
robh+dt@kernel.org
Cc: gregkh@linuxfoundation.org, david.brown@linaro.org,
mark.rutland@arm.com, lgirdwood@gmail.com, plai@codeaurora.org,
tiwai@suse.com, perex@perex.cz, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, rohkumar@qti.qualcomm.com,
spatakok@qti.qualcomm.com
Subject: Re: [PATCH v7 08/24] ASoC: qdsp6: q6core: Add q6core driver
Date: Wed, 9 May 2018 07:06:04 +0100 [thread overview]
Message-ID: <9ea47387-d849-19e8-1075-74a5e7e11a22@linaro.org> (raw)
In-Reply-To: <46511158-ed1d-7f07-0a8f-b325c088e386@codeaurora.org>
Thanks Banajit for the review!
On 04/05/18 20:04, Banajit Goswami wrote:
>> +
>> +static int q6core_callback(struct apr_device *adev, struct
>> apr_resp_pkt *data)
>> +{
>> + struct q6core *core = dev_get_drvdata(&adev->dev);
>> + struct aprv2_ibasic_rsp_result_t *result;
>> + struct apr_hdr *hdr = &data->hdr;
>> +
>> + result = data->payload;
>> + switch (hdr->opcode) {
>> + case APR_BASIC_RSP_RESULT:{
>> + result = data->payload;
>> + switch (result->opcode) {
>> + case AVCS_GET_VERSIONS:
>> + if (result->status == ADSP_EUNSUPPORTED)
>> + core->get_version_supported = false;
>> + core->resp_received = true;
>> + break;
>> + case AVCS_CMD_GET_FWK_VERSION:
>> + if (result->status == ADSP_EUNSUPPORTED)
>> + core->fwk_version_supported = false;
>> + core->resp_received = true;
>> + break;
>> + case AVCS_CMD_ADSP_EVENT_GET_STATE:
>> + if (result->status == ADSP_EUNSUPPORTED)
>> + core->get_state_supported = false;
>> + core->resp_received = true;
>> + break;
>> + }
>> + break;
>> + }
>> + case AVCS_CMDRSP_GET_FWK_VERSION: {
>> + struct avcs_cmdrsp_get_fwk_version *fwk;
>> + int bytes;
>> +
>> + fwk = data->payload;
>> + core->fwk_version_supported = true;
>> + bytes = sizeof(*fwk) + fwk->num_services *
>> + sizeof(fwk->svc_api_info[0]);
>> +
>> + core->fwk_version = kzalloc(bytes, GFP_ATOMIC);
>> + if (!core->fwk_version)
>> + return -ENOMEM;
> When the above allocation fails, core->fwk_version_supported will be
> still true, and q6core_get_fwk_versions() will return 0 (timeout as
> core->resp_received will not be set to true). This can cause a NULL
> pointer dereference inside the if() loop pointed below (added comment).
> Please move the line to set core->fwk_version_supported flag to after
> memset() to copy fwk version info.
Yes, makes sense, I fixed this and other comments in v8.
thanks,
srini
>> +
>> + memcpy(core->fwk_version, data->payload, bytes);
>> +
>> + core->resp_received = true;
>> +
>> + break;
>> + }
>> + case AVCS_GET_VERSIONS_RSP: {
>> + struct avcs_cmdrsp_get_version *v;
>> + int len;
>> +
>> + v = data->payload;
>> + core->get_version_supported = true;
>> +
next prev parent reply other threads:[~2018-05-09 6:06 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 12:07 [PATCH v7 00/24] ASoC: qcom: Add support to QDSP based Audio Srinivas Kandagatla
2018-05-01 12:07 ` [PATCH v7 01/24] soc: qcom dt-bindings: Add APR bus bindings Srinivas Kandagatla
2018-05-03 23:30 ` [alsa-devel] " Banajit Goswami
2018-05-04 17:33 ` Bjorn Andersson
2018-05-01 12:07 ` [PATCH v7 02/24] soc: qcom: Add APR bus driver Srinivas Kandagatla
2018-05-04 17:45 ` Bjorn Andersson
2018-05-11 3:18 ` Applied "soc: qcom: Add APR bus driver" to the asoc tree Mark Brown
2018-05-01 12:07 ` [PATCH v7 03/24] ASoC: qdsp6: dt-bindings: Add q6core dt bindings Srinivas Kandagatla
2018-05-03 23:45 ` Banajit Goswami
2018-05-01 12:08 ` [PATCH v7 04/24] ASoC: qdsp6: dt-bindings: Add q6afe " Srinivas Kandagatla
2018-05-01 12:37 ` Rob Herring
2018-05-03 23:50 ` Banajit Goswami
2018-05-11 3:17 ` Applied "ASoC: qdsp6: dt-bindings: Add q6afe dt bindings" to the asoc tree Mark Brown
2018-05-01 12:08 ` [PATCH v7 05/24] ASoC: qdsp6: dt-bindings: Add q6adm dt bindings Srinivas Kandagatla
2018-05-03 23:53 ` Banajit Goswami
2018-05-01 12:08 ` [PATCH v7 06/24] ASoC: qdsp6: dt-bindings: Add q6asm " Srinivas Kandagatla
2018-05-03 23:56 ` Banajit Goswami
2018-05-01 12:08 ` [PATCH v7 07/24] ASoC: qdsp6: q6common: Add qdsp6 helper functions Srinivas Kandagatla
2018-05-04 1:35 ` Banajit Goswami
2018-05-11 3:15 ` Applied "ASoC: qdsp6: q6common: Add qdsp6 helper functions" to the asoc tree Mark Brown
2018-05-01 12:08 ` [PATCH v7 08/24] ASoC: qdsp6: q6core: Add q6core driver Srinivas Kandagatla
2018-05-04 19:04 ` Banajit Goswami
2018-05-09 6:06 ` Srinivas Kandagatla [this message]
2018-05-01 12:08 ` [PATCH v7 09/24] ASoC: qdsp6: q6afe: Add q6afe driver Srinivas Kandagatla
2018-05-09 2:40 ` Banajit Goswami
2018-05-01 12:08 ` [PATCH v7 10/24] ASoC: qdsp6: qdafe: Add SLIMBus port Support Srinivas Kandagatla
2018-05-09 2:55 ` Banajit Goswami
2018-05-01 12:08 ` [PATCH v7 11/24] ASoC: qdsp6: q6afe: Add support to MI2S ports Srinivas Kandagatla
2018-05-09 3:21 ` Banajit Goswami
2018-05-09 6:05 ` Srinivas Kandagatla
2018-05-01 12:08 ` [PATCH v7 12/24] ASoC: qdsp6: q6afe: Add support to MI2S sysclks Srinivas Kandagatla
2018-05-09 4:29 ` Banajit Goswami
2018-05-01 12:08 ` [PATCH v7 13/24] ASoC: qdsp6: q6adm: Add q6adm driver Srinivas Kandagatla
2018-05-09 7:55 ` Banajit Goswami
2018-05-09 8:08 ` Srinivas Kandagatla
2018-05-01 12:08 ` [PATCH v7 14/24] ASoC: qdsp6: q6asm: Add q6asm driver Srinivas Kandagatla
2018-05-09 8:10 ` Banajit Goswami
2018-05-09 8:15 ` Srinivas Kandagatla
2018-05-01 12:08 ` [PATCH v7 15/24] ASoC: qdsp6: q6asm: Add support to memory map and unmap Srinivas Kandagatla
2018-05-09 8:23 ` Banajit Goswami
2018-05-01 12:08 ` [PATCH v7 16/24] ASoC: qdsp6: q6asm: Add support to audio stream apis Srinivas Kandagatla
2018-05-04 7:11 ` [alsa-devel] " Rohit Kumar
2018-05-04 8:24 ` Srinivas Kandagatla
2018-05-09 10:16 ` Banajit Goswami
2018-05-01 12:08 ` [PATCH v7 17/24] ASoC: qdsp6: q6routing: Add q6routing driver Srinivas Kandagatla
2018-05-09 8:56 ` Banajit Goswami
2018-05-01 12:08 ` [PATCH v7 18/24] ASoC: qdsp6: q6routing: Add support to all SLIMBus Mixers Srinivas Kandagatla
2018-05-09 8:39 ` Banajit Goswami
2018-05-01 12:08 ` [PATCH v7 19/24] ASoC: qdsp6: q6routing: Add support to MI2S Mixers Srinivas Kandagatla
2018-05-09 8:34 ` Banajit Goswami
2018-05-01 12:08 ` [PATCH v7 20/24] ASoC: qdsp6: q6afe: Add q6afe dai driver Srinivas Kandagatla
2018-05-09 9:42 ` Banajit Goswami
2018-05-09 9:43 ` Srinivas Kandagatla
2018-05-01 12:08 ` [PATCH v7 21/24] ASoC: qdsp6: q6asm: Add q6asm " Srinivas Kandagatla
2018-05-09 9:57 ` Banajit Goswami
2018-05-01 12:08 ` [PATCH v7 22/24] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings Srinivas Kandagatla
2018-05-09 9:01 ` Banajit Goswami
2018-05-01 12:08 ` [PATCH v7 23/24] ASoC: qcom: apq8096: Add db820c machine driver Srinivas Kandagatla
2018-05-09 9:15 ` Banajit Goswami
2018-05-09 10:03 ` Srinivas Kandagatla
2018-05-01 12:08 ` [PATCH v7 24/24] MAINTAINERS: Add myself as co-maintainer of qcom audio Srinivas Kandagatla
2018-05-09 9:16 ` Banajit Goswami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ea47387-d849-19e8-1075-74a5e7e11a22@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=andy.gross@linaro.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohkumar@qti.qualcomm.com \
--cc=spatakok@qti.qualcomm.com \
--cc=tiwai@suse.com \
--subject='Re: [PATCH v7 08/24] ASoC: qdsp6: q6core: Add q6core driver' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).