LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Alan Stern <stern@rowland.harvard.edu>, Jim Lin <jilin@nvidia.com>
Cc: gregkh@linuxfoundation.org, mathias.nyman@intel.com,
	hminas@synopsys.com, kai.heng.feng@canonical.com,
	drinkcat@chromium.org, prime.zeng@hisilicon.com,
	malat@debian.org, nsaenzjulienne@suse.de, jflat@chromium.org,
	linus.walleij@linaro.org, clabbe@baylibre.com,
	colin.king@canonical.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/1] usb: xhci: Add Clear_TT_Buffer
Date: Tue, 7 May 2019 11:00:34 +0300	[thread overview]
Message-ID: <9ea9fd3e-cf1a-9015-6d21-377c2fd41e66@linux.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1905061053550.1585-100000@iolanthe.rowland.org>

On 6.5.2019 17.57, Alan Stern wrote:
> On Mon, 6 May 2019, Jim Lin wrote:
> 
>> USB 2.0 specification chapter 11.17.5 says "as part of endpoint halt
>> processing for full-/low-speed endpoints connected via a TT, the host
>> software must use the Clear_TT_Buffer request to the TT to ensure
>> that the buffer is not in the busy state".
>>
>> In our case, a full-speed speaker (ConferenceCam) is behind a high-
>> speed hub (ConferenceCam Connect), sometimes once we get STALL on a
>> request we may continue to get STALL with the folllowing requests,
>> like Set_Interface.
>>
>> Here we add Clear_TT_Buffer for the following Set_Interface requests
>> to get ACK successfully.
>>
>> Originally usb_hub_clear_tt_buffer uses urb->dev->devnum as device
>> address while sending Clear_TT_Buffer command, but this doesn't work
>> for XHCI.
> 
> Why doesn't it work for xHCI?  Clear-TT-Buffer is part of the USB 2.0
> spec; it should work exactly the same for xHCI as for a USB-2.0 host
> controller.
> 
> Alan Stern
> 

For other host controllers udev->devnum is the same as the address of the
usb device, chosen and set by usb core.

With xHC the controller hardware assigns the address, and won't be the same as
devnum.

The Clear-TT-Buffer request sent to the hub includes the address of the LS/FS
child device in wValue field. usb_hub_clear_tt_buffer() uses udev->devnum to set the
address wValue. This won't work for devices connected to xHC
    
-Mathias

  reply	other threads:[~2019-05-07  7:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-06 14:34 Jim Lin
2019-05-06 14:57 ` Alan Stern
2019-05-07  8:00   ` Mathias Nyman [this message]
2019-05-07 14:29     ` Alan Stern
2019-05-08 10:21       ` Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ea9fd3e-cf1a-9015-6d21-377c2fd41e66@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=clabbe@baylibre.com \
    --cc=colin.king@canonical.com \
    --cc=drinkcat@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hminas@synopsys.com \
    --cc=jflat@chromium.org \
    --cc=jilin@nvidia.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=malat@debian.org \
    --cc=mathias.nyman@intel.com \
    --cc=nsaenzjulienne@suse.de \
    --cc=prime.zeng@hisilicon.com \
    --cc=stern@rowland.harvard.edu \
    --subject='Re: [PATCH v4 1/1] usb: xhci: Add Clear_TT_Buffer' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).