LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] scsi: target: Remove unused argument of some functions
@ 2021-09-13  8:30 Li Feng
  2021-09-13 14:56 ` Himanshu Madhani
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Li Feng @ 2021-09-13  8:30 UTC (permalink / raw)
  To: Martin K. Petersen, open list:SCSI TARGET SUBSYSTEM,
	open list:SCSI TARGET SUBSYSTEM, open list
  Cc: Li Feng

The se_cmd is unused in these functions, just remove it.
Signed-off-by: Li Feng <fengli@smartx.com>
---
 drivers/target/target_core_xcopy.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c
index d4fe7cb2bd00..6bb20aa9c5bc 100644
--- a/drivers/target/target_core_xcopy.c
+++ b/drivers/target/target_core_xcopy.c
@@ -295,8 +295,7 @@ static int target_xcopy_parse_target_descriptors(struct se_cmd *se_cmd,
 	return -EINVAL;
 }
 
-static int target_xcopy_parse_segdesc_02(struct se_cmd *se_cmd, struct xcopy_op *xop,
-					unsigned char *p)
+static int target_xcopy_parse_segdesc_02(struct xcopy_op *xop, unsigned char *p)
 {
 	unsigned char *desc = p;
 	int dc = (desc[1] & 0x02);
@@ -332,9 +331,9 @@ static int target_xcopy_parse_segdesc_02(struct se_cmd *se_cmd, struct xcopy_op
 	return 0;
 }
 
-static int target_xcopy_parse_segment_descriptors(struct se_cmd *se_cmd,
-				struct xcopy_op *xop, unsigned char *p,
-				unsigned int sdll, sense_reason_t *sense_ret)
+static int target_xcopy_parse_segment_descriptors(struct xcopy_op *xop,
+				unsigned char *p, unsigned int sdll,
+				sense_reason_t *sense_ret)
 {
 	unsigned char *desc = p;
 	unsigned int start = 0;
@@ -362,7 +361,7 @@ static int target_xcopy_parse_segment_descriptors(struct se_cmd *se_cmd,
 		 */
 		switch (desc[0]) {
 		case 0x02:
-			rc = target_xcopy_parse_segdesc_02(se_cmd, xop, desc);
+			rc = target_xcopy_parse_segdesc_02(xop, desc);
 			if (rc < 0)
 				goto out;
 
@@ -840,8 +839,7 @@ static sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop)
 	 */
 	seg_desc = &p[16] + tdll;
 
-	rc = target_xcopy_parse_segment_descriptors(se_cmd, xop, seg_desc,
-						    sdll, &ret);
+	rc = target_xcopy_parse_segment_descriptors(xop, seg_desc, sdll, &ret);
 	if (rc <= 0)
 		goto out;
 
-- 
2.31.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: target: Remove unused argument of some functions
  2021-09-13  8:30 [PATCH] scsi: target: Remove unused argument of some functions Li Feng
@ 2021-09-13 14:56 ` Himanshu Madhani
  2021-09-15  3:41 ` Martin K. Petersen
  2021-09-22  4:45 ` Martin K. Petersen
  2 siblings, 0 replies; 4+ messages in thread
From: Himanshu Madhani @ 2021-09-13 14:56 UTC (permalink / raw)
  To: Li Feng
  Cc: Martin Petersen, open list:SCSI TARGET SUBSYSTEM,
	open list:SCSI TARGET SUBSYSTEM, open list



> On Sep 13, 2021, at 3:30 AM, Li Feng <fengli@smartx.com> wrote:
> 
> The se_cmd is unused in these functions, just remove it.
> Signed-off-by: Li Feng <fengli@smartx.com>
> ---
> drivers/target/target_core_xcopy.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c
> index d4fe7cb2bd00..6bb20aa9c5bc 100644
> --- a/drivers/target/target_core_xcopy.c
> +++ b/drivers/target/target_core_xcopy.c
> @@ -295,8 +295,7 @@ static int target_xcopy_parse_target_descriptors(struct se_cmd *se_cmd,
> 	return -EINVAL;
> }
> 
> -static int target_xcopy_parse_segdesc_02(struct se_cmd *se_cmd, struct xcopy_op *xop,
> -					unsigned char *p)
> +static int target_xcopy_parse_segdesc_02(struct xcopy_op *xop, unsigned char *p)
> {
> 	unsigned char *desc = p;
> 	int dc = (desc[1] & 0x02);
> @@ -332,9 +331,9 @@ static int target_xcopy_parse_segdesc_02(struct se_cmd *se_cmd, struct xcopy_op
> 	return 0;
> }
> 
> -static int target_xcopy_parse_segment_descriptors(struct se_cmd *se_cmd,
> -				struct xcopy_op *xop, unsigned char *p,
> -				unsigned int sdll, sense_reason_t *sense_ret)
> +static int target_xcopy_parse_segment_descriptors(struct xcopy_op *xop,
> +				unsigned char *p, unsigned int sdll,
> +				sense_reason_t *sense_ret)
> {
> 	unsigned char *desc = p;
> 	unsigned int start = 0;
> @@ -362,7 +361,7 @@ static int target_xcopy_parse_segment_descriptors(struct se_cmd *se_cmd,
> 		 */
> 		switch (desc[0]) {
> 		case 0x02:
> -			rc = target_xcopy_parse_segdesc_02(se_cmd, xop, desc);
> +			rc = target_xcopy_parse_segdesc_02(xop, desc);
> 			if (rc < 0)
> 				goto out;
> 
> @@ -840,8 +839,7 @@ static sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop)
> 	 */
> 	seg_desc = &p[16] + tdll;
> 
> -	rc = target_xcopy_parse_segment_descriptors(se_cmd, xop, seg_desc,
> -						    sdll, &ret);
> +	rc = target_xcopy_parse_segment_descriptors(xop, seg_desc, sdll, &ret);
> 	if (rc <= 0)
> 		goto out;
> 
> -- 
> 2.31.1
> 

Looks fine. 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: target: Remove unused argument of some functions
  2021-09-13  8:30 [PATCH] scsi: target: Remove unused argument of some functions Li Feng
  2021-09-13 14:56 ` Himanshu Madhani
@ 2021-09-15  3:41 ` Martin K. Petersen
  2021-09-22  4:45 ` Martin K. Petersen
  2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-09-15  3:41 UTC (permalink / raw)
  To: Li Feng
  Cc: Martin K. Petersen, open list:SCSI TARGET SUBSYSTEM,
	open list:SCSI TARGET SUBSYSTEM, open list


Li,

> The se_cmd is unused in these functions, just remove it.

Applied to 5.16/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: target: Remove unused argument of some functions
  2021-09-13  8:30 [PATCH] scsi: target: Remove unused argument of some functions Li Feng
  2021-09-13 14:56 ` Himanshu Madhani
  2021-09-15  3:41 ` Martin K. Petersen
@ 2021-09-22  4:45 ` Martin K. Petersen
  2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-09-22  4:45 UTC (permalink / raw)
  To: Li Feng, open list, open list:SCSI TARGET SUBSYSTEM,
	open list:SCSI TARGET SUBSYSTEM
  Cc: Martin K . Petersen

On Mon, 13 Sep 2021 16:30:45 +0800, Li Feng wrote:

> The se_cmd is unused in these functions, just remove it.
> 
> 

Applied to 5.16/scsi-queue, thanks!

[1/1] scsi: target: Remove unused argument of some functions
      https://git.kernel.org/mkp/scsi/c/7e642ca0375b

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-09-22  4:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13  8:30 [PATCH] scsi: target: Remove unused argument of some functions Li Feng
2021-09-13 14:56 ` Himanshu Madhani
2021-09-15  3:41 ` Martin K. Petersen
2021-09-22  4:45 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).