LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Thomas Chou <thomas@wytron.com.tw>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	David Brownell <dbrownell@users.sourceforge.net>,
	nios2-dev@sopc.et.ntust.edu.tw,
	Mike Frysinger <vapier@gentoo.org>,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org,
	spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH v2] spi: New driver for Altera SPI
Date: Sun, 16 Jan 2011 23:45:51 -0700	[thread overview]
Message-ID: <AANLkTi=D4Rcxbei2oo+EHc6X1O-2Oo+VWHAasK_JLj5W@mail.gmail.com> (raw)
In-Reply-To: <4D33E00E.5050802@wytron.com.tw>

On Sun, Jan 16, 2011 at 11:22 PM, Thomas Chou <thomas@wytron.com.tw> wrote:
> On 01/17/2011 01:59 PM, Stephen Rothwell wrote:
>>>
>>> +/*
>>> + * struct altera_spi_platform_data - platform data of the Altera SPI
>>> + * @interrupt: use intrrupt driven data transfer.
>>> + */
>>> +struct altera_spi_platform_data {
>>> +       int interrupt;
>>> +};
>>
>> Is there some reason that this struct definition cannot just be placed
>> in spi_altera.c and so save a whole extra file (and its inclusion)?
>>
>
> Hi Stephen,
>
> It is needed for board configuration file to attach this platform data,
> which is used to choose between interrupt driven data transfer or polling
> method. The data transfer rate is usually faster for polling, as interrupt
> overhead is higher.

In this case, that decision could simply be made based on whether or
not the device has an irq resource.  No irq == polled mode.

g.

  reply	other threads:[~2011-01-17  6:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-08  6:03 [PATCH] " Thomas Chou
2011-01-17  5:46 ` [PATCH v2] " Thomas Chou
2011-01-17  5:59   ` Stephen Rothwell
2011-01-17  6:22     ` Thomas Chou
2011-01-17  6:45       ` Grant Likely [this message]
2011-01-17  7:04         ` [PATCH v3] " Thomas Chou
2011-01-17  7:27           ` Sinan Akman
2011-01-18  1:33             ` Thomas Chou
2011-01-19  1:36             ` Thomas Chou
2011-01-17  6:56   ` [PATCH v2] " Grant Likely
2011-01-17  7:13     ` [PATCH v4] " Thomas Chou
2011-01-17  7:42       ` Grant Likely
2011-01-24  6:38         ` [PATCH v5] " Thomas Chou
2011-02-03 10:02           ` [PATCH v6] " Thomas Chou
2011-02-03 17:34             ` Grant Likely
2011-02-05 13:08               ` Thomas Chou
2011-02-05 14:02               ` [PATCH v7] " Thomas Chou
2011-02-06 20:23                 ` Peter Korsgaard
2011-02-08  2:43                   ` Thomas Chou
2011-02-08  5:21                   ` [PATCH v8] " Thomas Chou
2011-02-14  2:10                     ` [PATCH v9] " Thomas Chou
2011-02-14  2:20                       ` Ryan Mallon
2011-02-15  7:04                         ` Thomas Chou
2011-02-15  9:12                           ` Ryan Mallon
2011-02-15 19:42                           ` Grant Likely
2011-02-15 21:58                             ` Ryan Mallon
2011-02-16  2:47                       ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=D4Rcxbei2oo+EHc6X1O-2Oo+VWHAasK_JLj5W@mail.gmail.com' \
    --to=grant.likely@secretlab.ca \
    --cc=dbrownell@users.sourceforge.net \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nios2-dev@sopc.et.ntust.edu.tw \
    --cc=sfr@canb.auug.org.au \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=thomas@wytron.com.tw \
    --cc=vapier@gentoo.org \
    --subject='Re: [PATCH v2] spi: New driver for Altera SPI' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).