LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Minchan Kim <minchan.kim@gmail.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: werner <w.landgraf@ru.ru>,
	akpm@linux-foundation.org, hannes@cmpxchg.org,
	idryomov@gmail.com, rostedt@goodmis.org,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	Johannes Weiner <jweiner@redhat.com>
Subject: Re: [PATCH] thp: fix PARAVIRT x86 32bit noPAE
Date: Sat, 22 Jan 2011 12:18:02 +0900	[thread overview]
Message-ID: <AANLkTi=XmwRN6n5Ud_JGH=+PZShgdfE=-H96ije5uCm2@mail.gmail.com> (raw)
In-Reply-To: <20110122021226.GQ9506@random.random>

On Sat, Jan 22, 2011 at 11:12 AM, Andrea Arcangeli <aarcange@redhat.com> wrote:
> I reproduced your 32bit x86 problem with an initramfs with a hugepage
> benchmark placed as /init inside KVM (not exactly an extensive test
> but it was trivial to reproduce). I tested below fix with HIGHMEM4G
> and HIGHMEM64G with PARAVIRT=y (and verified setting PARAVIRT=n fixed
> it, in other email Minchan also verified that setting HIGHMEM64G=y
> also fixed it, to confirm my theory the problem was the below #ifdef).
>
> The stress test reaches exit() successfully now (before the fix it
> crashed in out_of_memory() instead of do_exit as expected):
>
> NMI watchdog disabled for cpu0: unable to create perf event: -2
> �Kernel panic - not syncing: Attempted to kill init!
> Pid: 1, comm: init Not tainted 2.6.37+ #17
> Call Trace:
>  [<c14351d2>] ? panic+0x57/0x161
>  [<c107439b>] ? trace_hardirqs_on+0xb/0x10
>  [<c1045321>] ? do_exit+0x6b1/0x6e0
>  [<c10728ab>] ? trace_hardirqs_off+0xb/0x10
>  [<c1045389>] ? do_group_exit+0x39/0xa0
>  [<c1045403>] ? sys_exit_group+0x13/0x20
>  [<c1002d9c>] ? sysenter_do_call+0x12/0x3c
> QEMU 0.12.1 monitor - type 'help' for more information
> (qemu) quit
>
> ====
> Subject: thp: fix PARAVIRT x86 32bit noPAE
>
> From: Andrea Arcangeli <aarcange@redhat.com>
>
> This fixes TRANSPARENT_HUGEPAGE=y with PARAVIRT=y and HIGHMEM64=n.
>
> The #ifdef that this patch removes was erratically introduced to fix a build
> error for noPAE (where pmd.pmd doesn't exist). So then the kernel built but it
> failed at runtime because set_pmd_at was a noop. This will correct it by
> enabling set_pmd_at for noPAE mode too.
>
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>

It works well in my system until kernel compile completed while dd
if=/dev/sda3 of=/dev/zero and really slow web browsing.

Thanks, Andrea.

Reported-by: Minchan Kim <minchan.kim@gmail.com>
Tested-by: Minchan Kim <minchan.kim@gmail.com>


-- 
Kind regards,
Minchan Kim

      reply	other threads:[~2011-01-22  3:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-21 10:43 2.6.38-rc1 problems with khugepaged werner
2011-01-21 19:17 ` Andrea Arcangeli
2011-01-21 21:14   ` Steven Rostedt
2011-01-22  2:12   ` [PATCH] thp: fix PARAVIRT x86 32bit noPAE Andrea Arcangeli
2011-01-22  3:18     ` Minchan Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=XmwRN6n5Ud_JGH=+PZShgdfE=-H96ije5uCm2@mail.gmail.com' \
    --to=minchan.kim@gmail.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=idryomov@gmail.com \
    --cc=jweiner@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    --cc=w.landgraf@ru.ru \
    --subject='Re: [PATCH] thp: fix PARAVIRT x86 32bit noPAE' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).