Re: [PATCH 1/6] x86: Change get_max_mapped() to inline

[Yinghai Lu <yinghai@kernel.org>]

On Wed, Dec 29, 2010 at 3:05 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 12/27/2010 04:47 PM, Yinghai Lu wrote:
>>
>> Move it into head file. to prepare use it in other files.
>>
>> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>>
>> ---
>>  arch/x86/include/asm/page_types.h |    5 +++++
>>  arch/x86/kernel/setup.c           |    9 ---------
>>  2 files changed, 5 insertions(+), 9 deletions(-)
>>
>> Index: linux-2.6/arch/x86/include/asm/page_types.h
>> ===================================================================
>> --- linux-2.6.orig/arch/x86/include/asm/page_types.h
>> +++ linux-2.6/arch/x86/include/asm/page_types.h
>> @@ -45,6 +45,11 @@ extern int devmem_is_allowed(unsigned lo
>>  extern unsigned long max_low_pfn_mapped;
>>  extern unsigned long max_pfn_mapped;
>>
>> +static inline u64 get_max_mapped(void)
>> +{
>> +     return (u64)max_pfn_mapped<<PAGE_SHIFT;
>> +}
>> +
>>  extern unsigned long init_memory_mapping(unsigned long start,
>>                                        unsigned long end);
>>
>
> This is broken.  <asm/page_types.h> doesn't include <linux/types.h>
> which is required for the u64 type -- a simple compile test would have
> told you this.

compile test fail on 32 bit?

> Furthermore, it seems to me that it would make more
> sense for this to be phys_addr_t instead of u64; would you agree?

yes.