LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pierre Tardy <tardyp@gmail.com>
To: Chris Ball <cjb@laptop.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Pierre Tardy <pierre.tardy@intel.com>
Subject: Re: [PATCH 3/3] mmc: remove anti clock gating quirk for wl1271
Date: Thu, 20 Jan 2011 08:17:51 +0100	[thread overview]
Message-ID: <AANLkTingXmestJGOpi0A0eywz63iKA0q=S1FFb8-q4OO@mail.gmail.com> (raw)
In-Reply-To: <20110120041412.GA5274@void.printf.net>

>
> This adds a defined-but-not-used warning.  The MMC tree doesn't
> currently generate any warnings, so it would be good to avoid adding new
> ones, though I understand why it might make sense in this case.
Yes, this is supposed to be used by future user patches.

Do you suggest to add __attribute__ ((unused)), or we just completly
remove those and will add them whenever we have user?

>>  static const struct mmc_fixup mmc_fixup_methods[] = {
>>       { SDIO_ANY_ID, SDIO_ANY_ID,
>>               add_quirk_for_sdio_devices, MMC_QUIRK_BROKEN_CLK_GATING }
>> +     { SDIO_VENDOR_ID_TI, SDIO_DEVICE_ID_TI_WL1271,
>> +             remove_quirk_hook, MMC_QUIRK_BROKEN_CLK_GATING },
>>       { 0 }
>>  };
>>
>
> This doesn't compile, missing a comma.  Was it tested?
Hum, I must have screwed up with patch version.
I'm using this every day,,,

Regards,
Pierre

  reply	other threads:[~2011-01-20  7:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-09 16:26 [PATCH 0/3] mmc: add quirks.c file and CLK_GATING users Pierre Tardy
2011-01-09 16:26 ` [PATCH 1/3] mmc: add per device quirk placeholder Pierre Tardy
2011-01-10 16:04   ` Philip Rakity
2011-01-10 17:02     ` Pierre Tardy
2011-01-22 22:55   ` Ohad Ben-Cohen
2011-01-09 16:26 ` [PATCH 2/3] mmc: add MMC_QUIRK_BROKEN_CLK_GATING Pierre Tardy
2011-01-10 15:58   ` Philip Rakity
2011-01-10 16:57     ` Pierre Tardy
2011-01-10 17:18       ` Philip Rakity
2011-01-09 16:26 ` [PATCH 3/3] mmc: remove anti clock gating quirk for wl1271 Pierre Tardy
2011-01-20  4:14   ` Chris Ball
2011-01-20  7:17     ` Pierre Tardy [this message]
2011-01-22 14:47       ` Chris Ball
2011-01-10 22:01 ` [PATCH 0/3] mmc: add quirks.c file and CLK_GATING users Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTingXmestJGOpi0A0eywz63iKA0q=S1FFb8-q4OO@mail.gmail.com' \
    --to=tardyp@gmail.com \
    --cc=cjb@laptop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=pierre.tardy@intel.com \
    --subject='Re: [PATCH 3/3] mmc: remove anti clock gating quirk for wl1271' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).