LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Denis Kirjanov <kirjanov@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Vipin Mehta <vmehta@atheros.com>,
devel@driverdev.osuosl.org, Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/15] staging: ath6kl: wmi.h: Convert packed structures with A_BOOL to u32
Date: Fri, 28 Jan 2011 09:22:11 +0300 [thread overview]
Message-ID: <AANLkTintmdzz0bha3TzfsgMut2zrzt1X5TLYWCvm9gm2@mail.gmail.com> (raw)
In-Reply-To: <d1deb8a42497651898ad03bda9018d9deca93f12.1296186677.git.joe@perches.com>
On Fri, Jan 28, 2011 at 7:04 AM, Joe Perches <joe@perches.com> wrote:
> From: Joe Perches <joe@atheros-desktop.(none)>
>
> These structures are device native and need to be 4 bytes long.
>
> Signed-off-by: Joe Perches <joe@atheros-desktop.(none)>
> ---
You should fix your email address here
> drivers/staging/ath6kl/include/common/wmi.h | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/ath6kl/include/common/wmi.h b/drivers/staging/ath6kl/include/common/wmi.h
> index c75d310..eb8f7ba 100644
> --- a/drivers/staging/ath6kl/include/common/wmi.h
> +++ b/drivers/staging/ath6kl/include/common/wmi.h
> @@ -635,8 +635,8 @@ typedef enum {
> } WMI_SCAN_TYPE;
>
> typedef PREPACK struct {
> - A_BOOL forceFgScan;
> - A_BOOL isLegacy; /* For Legacy Cisco AP compatibility */
> + u32 forceFgScan;
> + u32 isLegacy; /* For Legacy Cisco AP compatibility */
> A_UINT32 homeDwellTime; /* Maximum duration in the home channel(milliseconds) */
> A_UINT32 forceScanInterval; /* Time interval between scans (milliseconds)*/
> A_UINT8 scanType; /* WMI_SCAN_TYPE */
> @@ -1241,7 +1241,7 @@ typedef PREPACK struct {
> * WMI_ENABLE_RM_CMDID
> */
> typedef PREPACK struct {
> - A_BOOL enable_radio_measurements;
> + u32 enable_radio_measurements;
> } POSTPACK WMI_ENABLE_RM_CMD;
>
> /*
> @@ -2638,7 +2638,7 @@ typedef PREPACK struct {
> } POSTPACK WMI_SET_KEEPALIVE_CMD;
>
> typedef PREPACK struct {
> - A_BOOL configured;
> + u32 configured;
> A_UINT8 keepaliveInterval;
> } POSTPACK WMI_GET_KEEPALIVE_CMD;
>
> @@ -2717,8 +2717,8 @@ typedef PREPACK struct {
> } POSTPACK WMI_SET_IP_CMD;
>
> typedef PREPACK struct {
> - A_BOOL awake;
> - A_BOOL asleep;
> + u32 awake;
> + u32 asleep;
> } POSTPACK WMI_SET_HOST_SLEEP_MODE_CMD;
>
> typedef enum {
> @@ -2726,7 +2726,7 @@ typedef enum {
> } WMI_WOW_FILTER;
>
> typedef PREPACK struct {
> - A_BOOL enable_wow;
> + u32 enable_wow;
> WMI_WOW_FILTER filter;
> A_UINT16 hostReqDelay;
> } POSTPACK WMI_SET_WOW_MODE_CMD;
> @@ -3010,7 +3010,7 @@ typedef PREPACK struct {
> } POSTPACK WMI_AP_PROT_SCAN_TIME_CMD;
>
> typedef PREPACK struct {
> - A_BOOL flag;
> + u32 flag;
> A_UINT16 aid;
> } POSTPACK WMI_AP_SET_PVB_CMD;
>
> --
> 1.7.4.rc3
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>
--
Regards,
Denis
next prev parent reply other threads:[~2011-01-28 6:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 4:04 [git pull-request and PATCH 00/15] staging: ath6kl: Cleanups Joe Perches
2011-01-28 4:04 ` [PATCH 01/15] staging: ath6kl: Update cfg80211 to recent calling convention changes Joe Perches
2011-01-28 7:35 ` Dan Carpenter
2011-01-28 7:41 ` Dan Carpenter
2011-01-28 4:04 ` [PATCH 02/15] staging: ath6kl: Convert enum A_STATUS to int Joe Perches
2011-01-28 4:04 ` [PATCH 03/15] staging: ath6kl: Remove A_SUCCESS macro Joe Perches
2011-01-28 4:04 ` [PATCH 04/15] staging: ath6kl: Remove A_FAILED macro Joe Perches
2011-01-28 4:04 ` [PATCH 06/15] staging: ath6kl: Convert bypasswmi to bool Joe Perches
2011-01-28 4:04 ` [PATCH 07/15] staging: ath6kl: Convert type of streamExists to A_UINT8 Joe Perches
2011-01-28 4:04 ` [PATCH 08/15] staging: ath6kl: Convert BDADDR_Present uses to TRUE/FALSE bugfix Joe Perches
2011-01-28 4:04 ` [PATCH 09/15] staging: ath6kl: Convert A_BOOL compressed sets from 0 to FALSE Joe Perches
2011-01-28 4:04 ` [PATCH 10/15] staging: ath6kl: Convert " Joe Perches
2011-01-28 4:04 ` [PATCH 11/15] staging: ath6kl: cfg80211: Convert forceFgScan to A_UINT32 Joe Perches
2011-01-28 4:04 ` [PATCH 12/15] staging: ath6kl: Convert A_UINT8 is_amsdu and is_acl_data_frame to A_BOOL Joe Perches
2011-01-28 11:42 ` Dan Carpenter
2011-01-28 15:45 ` Joe Perches
2011-01-28 4:04 ` [PATCH 13/15] staging: ath6kl: Convert A_NETBUF_QUEUE_EMPTY to return TRUE or FALSE Joe Perches
2011-01-28 4:04 ` [PATCH 14/15] staging: ath6kl: Convert sets of scanSpecificSsid to TRUE/FALSE Joe Perches
2011-01-28 4:04 ` [PATCH 15/15] staging: ath6kl: Convert tspecCompliance from A_BOOL to int Joe Perches
[not found] ` <d1deb8a42497651898ad03bda9018d9deca93f12.1296186677.git.joe@perches.com>
2011-01-28 6:22 ` Denis Kirjanov [this message]
2011-01-28 19:47 ` [git pull-request and PATCH 00/15] staging: ath6kl: Cleanups Vipin Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTintmdzz0bha3TzfsgMut2zrzt1X5TLYWCvm9gm2@mail.gmail.com \
--to=kirjanov@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vmehta@atheros.com \
--subject='Re: [PATCH 05/15] staging: ath6kl: wmi.h: Convert packed structures with A_BOOL to u32' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).