LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Minchan Kim <minchan.kim@gmail.com>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: gregkh@suse.de, Chris Mason <chris.mason@oracle.com>,
	akpm@linux-foundation.org, torvalds@linux-foundation.org,
	matthew@wil.cx, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	ngupta@vflare.org, jeremy@goop.org,
	Kurt Hackel <kurt.hackel@oracle.com>,
	npiggin@kernel.dk, riel@redhat.com,
	Konrad Wilk <konrad.wilk@oracle.com>,
	mel@csn.ul.ie, kosaki.motohiro@jp.fujitsu.com,
	sfr@canb.auug.org.au, wfg@mail.ustc.edu.cn, tytso@mit.edu,
	viro@zeniv.linux.org.uk, hughd@google.com, hannes@cmpxchg.org
Subject: Re: [PATCH V2 2/3] drivers/staging: zcache: host services and PAM services
Date: Thu, 10 Feb 2011 08:57:36 +0900	[thread overview]
Message-ID: <AANLkTinwZJrAWo_Fat3e6WwLn+MPdZyFVgT6sckLCUo3@mail.gmail.com> (raw)
In-Reply-To: <5c529b08-cf36-43c7-b368-f3f602faf358@default>

On Thu, Feb 10, 2011 at 1:39 AM, Dan Magenheimer
<dan.magenheimer@oracle.com> wrote:
>
>
>> From: Minchan Kim [mailto:minchan.kim@gmail.com]
>
>> As I read your comment, I can't find the benefit of zram compared to
>> frontswap.
>
> Well, I am biased, but I agree that frontswap is a better technical
> solution than zram. ;-)  But "dynamic-ity" is very important to
> me and may be less important to others.
>
> I thought of these other differences, both technical and
> non-technical:
>
> - Zram is minimally invasive to the swap subsystem, requiring only
>  one hook which is already upstream (though see below) and is
>  apparently already used by some Linux users.  Frontswap is somewhat

Yes. I think what someone is using it is a problem.

>  more invasive and, UNTIL zcache-was-kztmem was posted a few weeks
>  ago, had no non-Xen users (though some distros are already shipping
>  the hooks in their kernels because Xen supports it); as a result,
>  frontswap has gotten almost no review by kernel swap subsystem
>  experts who I'm guessing weren't interested in anything that
>  required Xen to use... hopefully that barrier is now resolved
>  (but bottom line is frontswap is not yet upstream).

That's why I suggested to remove frontswap in this turn.
If any swap experts has a interest, maybe you can't receive any ack or
review about the part in this series. Maybe  maintainers ends up
hesitating the merge.

If zcache except frontswap is merged into mainline or receive enough
review, then you can try merging frontswap as further step.

Thanks.

-- 
Kind regards,
Minchan Kim

  parent reply	other threads:[~2011-02-09 23:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-07  3:26 Dan Magenheimer
2011-02-08 22:48 ` Minchan Kim
2011-02-08 23:27   ` Dan Magenheimer
2011-02-08 23:56     ` Minchan Kim
2011-02-09 16:39       ` Dan Magenheimer
2011-02-09 17:36         ` Nitin Gupta
2011-02-09 23:46           ` Minchan Kim
2011-02-10  1:17             ` Nitin Gupta
2011-02-09 23:57         ` Minchan Kim [this message]
2011-02-09 23:58           ` Minchan Kim
2011-02-15 16:53 ` Konrad Rzeszutek Wilk
2011-02-15 17:25   ` Greg KH
2011-02-15 18:18     ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinwZJrAWo_Fat3e6WwLn+MPdZyFVgT6sckLCUo3@mail.gmail.com \
    --to=minchan.kim@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=chris.mason@oracle.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=gregkh@suse.de \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=jeremy@goop.org \
    --cc=konrad.wilk@oracle.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=kurt.hackel@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=matthew@wil.cx \
    --cc=mel@csn.ul.ie \
    --cc=ngupta@vflare.org \
    --cc=npiggin@kernel.dk \
    --cc=riel@redhat.com \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wfg@mail.ustc.edu.cn \
    --subject='Re: [PATCH V2 2/3] drivers/staging: zcache: host services and PAM services' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).