LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Zhang Wei" <Wei.Zhang@freescale.com>
To: <pterry@vmetro.com>
Cc: "Kumar Gala" <galak@kernel.crashing.org>,
	<linuxppc-dev@ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 4/6] Add multi mport support.
Date: Fri, 1 Feb 2008 12:06:26 +0800	[thread overview]
Message-ID: <ABF87B0B6A38C0458E319AC973ED68AEBD08C8@zch01exm26.fsl.freescale.net> (raw)
In-Reply-To: <1201804525.14266.45.camel@pterry-fc6.micromemory.com>

Hi, Phil,

> -----Original Message-----
> From: Phil Terry [mailto:pterry@micromemory.com] 
> 
> On Thu, 2008-01-31 at 14:30 +0800, Zhang Wei wrote:
> >  
> > > >
> > I consider each RIO controller will has its own network, 
> the device IDs
> > should be
> > unique only in its port network.
> Hmmm, I see two cases:

Good questions! They are very important and also my concern now.

> 
> 1. I have two mport to two controllers each connected to different
> physical fabrics. This system can act as an application bridge between
> the two fabrics.
> 

The current driver just looks two mport as two independent fabrics.
We can add bridge driver to implement your idea.

> 2. I have two mports to two controllers each connected directly or
> indirectly to the same fabric. I want to use the extra bandwidth and
> load balance and/or have a fall back redundant connection via an
> alternate physical connection to the fabric etc.
> 

That's a terrible thing in the current driver. Two mports get the same
 ID in one fabric. About the port bound, it's a good idea, I also need
 a new driver to support it.

In fact, our first mission is to make the RapidIO driver ported from ppc
to powerpc can
 be compiled and run. Fortunately, there is no more than one port in
processor now,
 we have time to implement it.

> What should be the rules for allocating the initial IDs to the two
> mports to allow system wide enumeration to work in both of the above
> cases? 
> 

A choice is add ID option into dts node. I have some ideas about RapidIO
 driver in u-boot. U-boot can assign ID in dts and tell kernel.

> What do you expect the semantics of higher level addressing to be:
>  a pair <mport,id>, where <x,n> is a different device from <y,n>,
>  a pair <mport,id>, where <x,n> is the same device as <y,n>,or
>  a singleton n, where n is unique and identifies the first 
> routing step
> of which controller, x or y, to use.

It seems the address pair is a must-be selection as pci bus.
But now, no connection between ports. Every operations in only
 in its own port view.

> I smell a can of worms.... :-)

A good nose! Thanks! :)

Cheers!
Wei

  reply	other threads:[~2008-02-01  4:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 10:30 [PATCH 1/6] Change RIO function mpc85xx_ to fsl_ Zhang Wei
2008-01-30 10:30 ` [PATCH 2/6] Add RapidIO option to kernel configuration Zhang Wei
2008-01-30 10:30   ` [PATCH 3/6] Move include/asm-ppc/rio.h to include/asm-powerpc/rio.h Zhang Wei
2008-01-30 10:30     ` [PATCH 4/6] Add multi mport support Zhang Wei
2008-01-30 10:30       ` [PATCH 5/6] Add OF-tree support to RapidIO controller driver Zhang Wei
2008-01-30 10:30         ` [PATCH 6/6] Change the kernel configurated RapidIO system size to auto-probing Zhang Wei
2008-02-05 16:43           ` Matt Porter
2008-02-05  5:44         ` [PATCH 5/6] Add OF-tree support to RapidIO controller driver Stephen Rothwell
2008-02-05 16:06           ` Kumar Gala
2008-02-18  7:24             ` Zhang Wei
2008-01-30 14:27       ` [PATCH 4/6] Add multi mport support Kumar Gala
2008-01-31  5:57         ` Zhang Wei
2008-01-31  6:15           ` Kumar Gala
2008-01-31  6:20             ` Kumar Gala
2008-01-31  6:30               ` Zhang Wei
2008-01-31 18:35                 ` Phil Terry
2008-02-01  4:06                   ` Zhang Wei [this message]
2008-02-05 16:29                 ` Matt Porter
2008-02-18  7:33                   ` Zhang Wei
2008-02-05 16:23           ` Matt Porter
2008-01-30 14:20     ` [PATCH 3/6] Move include/asm-ppc/rio.h to include/asm-powerpc/rio.h Kumar Gala
2008-01-31  3:36       ` Zhang Wei
2008-01-30 14:43 ` [PATCH 1/6] Change RIO function mpc85xx_ to fsl_ Kumar Gala
2008-01-31  6:04   ` Zhang Wei
2008-01-31  6:15     ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ABF87B0B6A38C0458E319AC973ED68AEBD08C8@zch01exm26.fsl.freescale.net \
    --to=wei.zhang@freescale.com \
    --cc=galak@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=pterry@vmetro.com \
    --subject='RE: [PATCH 4/6] Add multi mport support.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).