LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Zhang Wei" <Wei.Zhang@freescale.com>
To: "Kumar Gala" <galak@kernel.crashing.org>,
	"Stephen Rothwell" <sfr@canb.auug.org.au>
Cc: <mporter@kernel.crashing.org>, <linuxppc-dev@ozlabs.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 5/6] Add OF-tree support to RapidIO controller driver.
Date: Mon, 18 Feb 2008 15:24:30 +0800	[thread overview]
Message-ID: <ABF87B0B6A38C0458E319AC973ED68AEC3DEF3@zch01exm26.fsl.freescale.net> (raw)
In-Reply-To: <4A9328DB-F68C-4C09-B762-44FEA85DD12E@kernel.crashing.org>

 

> -----Original Message-----
> From: Kumar Gala [mailto:galak@kernel.crashing.org] 
> 
> 
> On Feb 4, 2008, at 11:44 PM, Stephen Rothwell wrote:
> 
> >>
> >> +	aw = *(u32 *)of_get_property(dev->node, "#address-cells", NULL);
> >> +	sw = *(u32 *)of_get_property(dev->node, "#size-cells", NULL);
> >
> > What happens if either of these properties is missing?
> 
> Should we add __must_check to of_get_property?
> 

You are right, I'll add the checking here.

Thanks!
Wei.

  reply	other threads:[~2008-02-18  7:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 10:30 [PATCH 1/6] Change RIO function mpc85xx_ to fsl_ Zhang Wei
2008-01-30 10:30 ` [PATCH 2/6] Add RapidIO option to kernel configuration Zhang Wei
2008-01-30 10:30   ` [PATCH 3/6] Move include/asm-ppc/rio.h to include/asm-powerpc/rio.h Zhang Wei
2008-01-30 10:30     ` [PATCH 4/6] Add multi mport support Zhang Wei
2008-01-30 10:30       ` [PATCH 5/6] Add OF-tree support to RapidIO controller driver Zhang Wei
2008-01-30 10:30         ` [PATCH 6/6] Change the kernel configurated RapidIO system size to auto-probing Zhang Wei
2008-02-05 16:43           ` Matt Porter
2008-02-05  5:44         ` [PATCH 5/6] Add OF-tree support to RapidIO controller driver Stephen Rothwell
2008-02-05 16:06           ` Kumar Gala
2008-02-18  7:24             ` Zhang Wei [this message]
2008-01-30 14:27       ` [PATCH 4/6] Add multi mport support Kumar Gala
2008-01-31  5:57         ` Zhang Wei
2008-01-31  6:15           ` Kumar Gala
2008-01-31  6:20             ` Kumar Gala
2008-01-31  6:30               ` Zhang Wei
2008-01-31 18:35                 ` Phil Terry
2008-02-01  4:06                   ` Zhang Wei
2008-02-05 16:29                 ` Matt Porter
2008-02-18  7:33                   ` Zhang Wei
2008-02-05 16:23           ` Matt Porter
2008-01-30 14:20     ` [PATCH 3/6] Move include/asm-ppc/rio.h to include/asm-powerpc/rio.h Kumar Gala
2008-01-31  3:36       ` Zhang Wei
2008-01-30 14:43 ` [PATCH 1/6] Change RIO function mpc85xx_ to fsl_ Kumar Gala
2008-01-31  6:04   ` Zhang Wei
2008-01-31  6:15     ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ABF87B0B6A38C0458E319AC973ED68AEC3DEF3@zch01exm26.fsl.freescale.net \
    --to=wei.zhang@freescale.com \
    --cc=galak@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mporter@kernel.crashing.org \
    --cc=sfr@canb.auug.org.au \
    --subject='RE: [PATCH 5/6] Add OF-tree support to RapidIO controller driver.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).