LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Zhang Wei" <Wei.Zhang@freescale.com>
To: "Dan Williams" <dan.j.williams@intel.com>
Cc: "Olof Johansson" <olof@lixom.net>, <sfr@canb.auug.org.au>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] Fix fsldma.c warning messages when it's compiled underPPC64.
Date: Thu, 13 Mar 2008 14:52:56 +0800 [thread overview]
Message-ID: <ABF87B0B6A38C0458E319AC973ED68AED32DBF@zch01exm26.fsl.freescale.net> (raw)
In-Reply-To: <e9c3a7c20803120929l41b9fec8m34db73d6e034461a@mail.gmail.com>
Hi, Dan,
I just consider if it could be reused on Freescale's 64bit processor in the future.
If we don't care this, I can let the driver only depends on PPC32.
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 27340a7..449c0ae 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -39,7 +39,7 @@ config INTEL_IOP_ADMA
config FSL_DMA
bool "Freescale MPC85xx/MPC83xx DMA support"
- depends on PPC
+ depends on PPC32
select DMA_ENGINE
---help---
Enable support for the Freescale DMA engine. Now, it support
Thanks!
Wei.
> -----Original Message-----
> From: dan.j.williams@gmail.com
>
> On Tue, Mar 11, 2008 at 7:10 PM, Zhang Wei
> <Wei.Zhang@freescale.com> wrote:
> > The reason is the val will be assigned to SR register, and
> SR register
> > is a 32-bit only register.
>
> If this is the case then why not disable the driver for PPC_64?
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 27340a7..89db937 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -40,6 +40,7 @@ config INTEL_IOP_ADMA
> config FSL_DMA
> bool "Freescale MPC85xx/MPC83xx DMA support"
> depends on PPC
> + depends on !PPC_64
> select DMA_ENGINE
> ---help---
> Enable support for the Freescale DMA engine. Now, it support
>
> --
> Dan
>
next prev parent reply other threads:[~2008-03-13 6:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 10:47 [PATCH] Fix fsldma.c warning messages when it's compiled under PPC64 Zhang Wei
2008-03-10 19:09 ` Dan Williams
2008-03-11 14:22 ` Olof Johansson
2008-03-12 2:10 ` [PATCH] Fix fsldma.c warning messages when it's compiled underPPC64 Zhang Wei
2008-03-12 16:29 ` Dan Williams
2008-03-13 6:52 ` Zhang Wei [this message]
2008-03-18 18:23 ` Scott Wood
2008-03-19 1:52 ` Zhang Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ABF87B0B6A38C0458E319AC973ED68AED32DBF@zch01exm26.fsl.freescale.net \
--to=wei.zhang@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sfr@canb.auug.org.au \
--subject='RE: [PATCH] Fix fsldma.c warning messages when it'\''s compiled underPPC64.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).