LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] clocksource: imx-tpm: correct -ETIME return condition check
@ 2018-04-19  6:04 Anson Huang
  2018-04-19  7:14 ` A.s. Dong
  2018-04-19 11:25 ` [tip:timers/urgent] clocksource/imx-tpm: Correct " tip-bot for Anson Huang
  0 siblings, 2 replies; 3+ messages in thread
From: Anson Huang @ 2018-04-19  6:04 UTC (permalink / raw)
  To: daniel.lezcano, tglx, linux-kernel; +Cc: Linux-imx

The additional brakets added to tpm_set_next_event's return
value computation causes (int) forced type conversion NOT
taking effect, and the incorrect value return will cause
various system timer issue, like RCU stall etc..

This patch removes the additional brakets to make sure
tpm_set_next_event always returns correct value.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
	resend, since I got failure message of sending mail to linux-kernel@vger.kernel.org.
 drivers/clocksource/timer-imx-tpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-imx-tpm.c b/drivers/clocksource/timer-imx-tpm.c
index 05d97a6..6c83184 100644
--- a/drivers/clocksource/timer-imx-tpm.c
+++ b/drivers/clocksource/timer-imx-tpm.c
@@ -114,7 +114,7 @@ static int tpm_set_next_event(unsigned long delta,
 	 * of writing CNT registers which may cause the min_delta event got
 	 * missed, so we need add a ETIME check here in case it happened.
 	 */
-	return (int)((next - now) <= 0) ? -ETIME : 0;
+	return (int)(next - now) <= 0 ? -ETIME : 0;
 }
 
 static int tpm_set_state_oneshot(struct clock_event_device *evt)
-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-19 11:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19  6:04 [PATCH] clocksource: imx-tpm: correct -ETIME return condition check Anson Huang
2018-04-19  7:14 ` A.s. Dong
2018-04-19 11:25 ` [tip:timers/urgent] clocksource/imx-tpm: Correct " tip-bot for Anson Huang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).