LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peng Fan <peng.fan@nxp.com>
To: Jacky Bai <ping.bai@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Anson Huang <anson.huang@nxp.com>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	Daniel Baluta <daniel.baluta@nxp.com>
Subject: RE: [PATCH] ARM64: dts: imx8m: fix aips dts node
Date: Tue, 25 Feb 2020 05:18:06 +0000	[thread overview]
Message-ID: <AM0PR04MB448131061921C313B830802D88ED0@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <VI1PR04MB69920BD928735E22A8B9928987ED0@VI1PR04MB6992.eurprd04.prod.outlook.com>

> Subject: RE: [PATCH] ARM64: dts: imx8m: fix aips dts node
> 
> > -----Original Message-----
> > From: Peng Fan <peng.fan@nxp.com>
> > Sent: Tuesday, February 25, 2020 11:44 AM
> > To: robh+dt@kernel.org; mark.rutland@arm.com; shawnguo@kernel.org;
> > s.hauer@pengutronix.de
> > Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> > <linux-imx@nxp.com>; devicetree@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > Anson Huang <anson.huang@nxp.com>; Leonard Crestez
> > <leonard.crestez@nxp.com>; Daniel Baluta <daniel.baluta@nxp.com>;
> Peng
> > Fan <peng.fan@nxp.com>
> > Subject: [PATCH] ARM64: dts: imx8m: fix aips dts node
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Per binding doc fsl,aips-bus.yaml, compatible and reg is required. And
> > for reg, the AIPS configuration space should be used, not all the AIPS bus
> space.
> >
> 
> Any reason that we need to add the aips bus compatible & reg back? The aips
> config space can only be write by secure world, linux has no permission to
> config the aips port. And it seems no driver use "fsl,aips" anymore.

dts is not only used for Linux. See what Rob commented,
https://lore.kernel.org/linux-arm-kernel/CAL_JsqLsQmv
M0Qsspj5n+1iy5X0TXaULonGtjKRkdOoSQVQmzw@mail.gmail.com/T/#u

Regards,
Peng.
> 
> BR
> Jacky Bai
> 
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 12 ++++++++----
> > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 16 ++++++++--------
> > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++------
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 12 ++++++++----
> >  4 files changed, 30 insertions(+), 22 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > index b3d0b29d7007..a4356d2047cd 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -227,7 +227,8 @@
> >  		ranges = <0x0 0x0 0x0 0x3e000000>;
> >
> >  		aips1: bus@30000000 {
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x301f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x30000000 0x30000000 0x400000>; @@ -496,7
> > +497,8 @@
> >  		};
> >
> >  		aips2: bus@30400000 {
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x305f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x30400000 0x30400000 0x400000>; @@ -555,7
> > +557,8 @@
> >  		};
> >
> >  		aips3: bus@30800000 {
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x309f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x30800000 0x30800000 0x400000>; @@ -800,7
> > +803,8 @@
> >  		};
> >
> >  		aips4: bus@32c00000 {
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x32df0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x32c00000 0x32c00000 0x400000>; diff --git
> > a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> > index f2775724377f..4848ce82f083 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> > @@ -203,8 +203,8 @@
> >  		ranges = <0x0 0x0 0x0 0x3e000000>;
> >
> >  		aips1: bus@30000000 {
> > -			compatible = "simple-bus";
> > -			reg = <0x30000000 0x400000>;
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x301f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges;
> > @@ -401,8 +401,8 @@
> >  		};
> >
> >  		aips2: bus@30400000 {
> > -			compatible = "simple-bus";
> > -			reg = <0x30400000 0x400000>;
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x305f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges;
> > @@ -461,8 +461,8 @@
> >  		};
> >
> >  		aips3: bus@30800000 {
> > -			compatible = "simple-bus";
> > -			reg = <0x30800000 0x400000>;
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x309f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges;
> > @@ -707,8 +707,8 @@
> >  		};
> >
> >  		aips4: bus@32c00000 {
> > -			compatible = "simple-bus";
> > -			reg = <0x32c00000 0x400000>;
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x32df0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges;
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index 71b0c8f23693..eb67f56cdfe2 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -144,8 +144,8 @@
> >  		ranges = <0x0 0x0 0x0 0x3e000000>;
> >
> >  		aips1: bus@30000000 {
> > -			compatible = "simple-bus";
> > -			reg = <0x30000000 0x400000>;
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x301f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges;
> > @@ -309,8 +309,8 @@
> >  		};
> >
> >  		aips2: bus@30400000 {
> > -			compatible = "simple-bus";
> > -			reg = <0x30400000 0x400000>;
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x305f0000 0x400000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges;
> > @@ -369,8 +369,8 @@
> >  		};
> >
> >  		aips3: bus@30800000 {
> > -			compatible = "simple-bus";
> > -			reg = <0x30800000 0x400000>;
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x309f0000 0x400000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges;
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 6a1e83922c71..07070464063d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -290,7 +290,8 @@
> >  		dma-ranges = <0x40000000 0x0 0x40000000 0xc0000000>;
> >
> >  		bus@30000000 { /* AIPS1 */
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x301f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x30000000 0x30000000 0x400000>; @@ -692,7
> > +693,8 @@
> >  		};
> >
> >  		bus@30400000 { /* AIPS2 */
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x305f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x30400000 0x30400000 0x400000>; @@ -751,7
> > +753,8 @@
> >  		};
> >
> >  		bus@30800000 { /* AIPS3 */
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x309f0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x30800000 0x30800000 0x400000>, @@ -1023,7
> > +1026,8 @@
> >  		};
> >
> >  		bus@32c00000 { /* AIPS4 */
> > -			compatible = "simple-bus";
> > +			compatible = "fsl,aips", "simple-bus";
> > +			reg = <0x32df0000 0x10000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> >  			ranges = <0x32c00000 0x32c00000 0x400000>;
> > --
> > 2.16.4


  reply	other threads:[~2020-02-25  5:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25  3:44 peng.fan
2020-02-25  4:15 ` Jacky Bai
2020-02-25  5:18   ` Peng Fan [this message]
2020-03-11  6:21 ` Shawn Guo
2020-03-11  7:07   ` Peng Fan
2020-03-11  7:07     ` Peng Fan
2020-03-11  7:14 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR04MB448131061921C313B830802D88ED0@AM0PR04MB4481.eurprd04.prod.outlook.com \
    --to=peng.fan@nxp.com \
    --cc=anson.huang@nxp.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=ping.bai@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --subject='RE: [PATCH] ARM64: dts: imx8m: fix aips dts node' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).